Defined notes and rules for BSI APP.4.4.A19 #12155
Conversation
|
Hi @benruland. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Start a new ephemeral environment with changes proposed in this pull request: ocp4 (from CTF) Environment (using Fedora as testing environment) Fedora Testing Environment Oracle Linux 8 Environment |
|
🤖 A k8s content image for this PR is available at: Click here to see how to deploy itIf you alread have Compliance Operator deployed: Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and: |
benruland
force-pushed
the
bsi-app-4.4-a19
branch
3 times, most recently
from
3b28165
to
8f3cabb
Compare
...nshift/high-availability/anti_affinity_or_topology_spread_constraints_in_deployment/rule.yml
Outdated
Show resolved
Hide resolved
...nshift/high-availability/anti_affinity_or_topology_spread_constraints_in_deployment/rule.yml
Outdated
Show resolved
Hide resolved
...nshift/high-availability/anti_affinity_or_topology_spread_constraints_in_deployment/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/high-availability/three_control_plane_nodes/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/high-availability/three_control_plane_nodes/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/high-availability/three_control_plane_nodes/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/high-availability/worker_nodes_in_two_zones_or_more/rule.yml
Outdated
Show resolved
Hide resolved
applications/openshift/high-availability/worker_nodes_in_two_zones_or_more/rule.yml
Outdated
Show resolved
Hide resolved
marcusburghardt
added
OpenShift
|
@benruland Hi, do you plan to act on @sluetze's feedback? |
Hey @yuumasato, sorry for the absence! I was swamped in projects and personal obligations... In two weeks, I will return and address the feedback. |
Rules include OpenShift node high availability and spreading over zones, and Anti-Affinity/TopologySpreadConstraints for Workload
benruland
force-pushed
the
bsi-app-4.4-a19
branch
from
8f3cabb
to
029d062
Compare
Co-authored-by: sluetze <13255307+sluetze@users.noreply.github.com>
benruland
force-pushed
the
bsi-app-4.4-a19
branch
from
3bc17ba
to
bb5d5e4
Compare
benruland
force-pushed
the
bsi-app-4.4-a19
branch
from
bb5d5e4
to
bd743c5
Compare
|
Hi @yuumasato, I adjusted this PR and also #12153 and #12154 according to the review. Could you take a look if it looks fine? |
|
Code Climate has analyzed commit bd743c5 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 59.5% (0.0% change). View more on Code Climate. |
|
/packit test |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
Description:
Notes / Rules for BSI APP4.4.A19
Rationale:
As we have multiple customers asking for a BSI profile to be included in the compliance-operator, we are contributing a profile. To provide a better review process, the individual controle are implemented as separate PRs.
This is a follow-up of #11659. It was breaken up for better reviewability.