OCPBUGS-42177: Fix resource quota

[Vincent056]

This PR fixes resource quota rule, resource_requests_quota did not include the updated jq filter from #12344

[github-actions]

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment

Oracle Linux 8 Environment

[github-actions]

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12399
This image was built from commit: 7a57333

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12399

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12399 make deploy-local

[codeclimate]

Code Climate has analyzed commit 7a57333 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

[xiaojiey]

Pre-merge verification pass with ghcr.io/complianceascode/k8scontent:12399:

% oc get resourcequota --all-namespaces
NAMESPACE                NAME                            AGE    REQUEST                                                              LIMIT
foo                      test-quota                      109m   count/daemonsets.apps: 0/0, count/deployments.apps: 0/0, pods: 0/0   limits.cpu: 0/0, limits.memory: 0/0
openshift-host-network   host-network-namespace-quotas   149m   count/daemonsets.apps: 0/0, count/deployments.apps: 0/0, pods: 0/0   limits.cpu: 0/0, limits.memory: 0/0
test-no-rate-limit       example-1                       116m   pods: 0/4, requests.cpu: 0/1, requests.memory: 0/1Gi                 limits.cpu: 0/2, limits.memory: 0/2Gi

% oc get ccr | grep resource-requests-quota
ocp4-moderate-resource-requests-quota                                            FAIL     medium
upstream-ocp4-moderate-resource-requests-quota                                   PASS     medium

% oc get ccr upstream-ocp4-moderate-resource-requests-quota -o=jsonpath={.instructions}
Run the following command to retrieve the ClusterResourceQuota objects in the system:
$ oc get clusterquota --all-namespaces
Make sure there exists at least one ClusterResourceQuota object in the cluster.
 
Or
 
Verify that the every non-control plane namespace has an appropriate ResourceQuota.
 
To get all the non-control plane namespaces, you can do the
following command $ oc get  namespaces -o json | jq '[.items[] | select((.metadata.name | startswith("openshift") | not) and (.metadata.name | startswith("kube-") | not) and .metadata.name != "default" and .metadata.name != "rhacs-operator" and (true)) | .metadata.name]'
 
To get all the non-control plane namespaces with a ResourceQuota, you can do the
following command $ oc get --all-namespaces resourcequota -o json | jq '[.items[] | select((.metadata.namespace | startswith("openshift") | not) and (.metadata.namespace | startswith("kube-") | not) and .metadata.namespace != "default" and .metadata.namespace != "rhacs-operator" and (true)) | .metadata.namespace] | unique'
 
Make sure that the namespaces displayed in the commands of the commands match.
Is it the case that Resource requests and limits is not set?%                                                                           

 % oc get  namespaces -o json | jq '[.items[] | select((.metadata.name | startswith("openshift") | not) and (.metadata.name | startswith("kube-") | not) and .metadata.name != "default" and .metadata.name != "rhacs-operator" and (true)) | .metadata.name]'
[
  "foo",
  "test-no-rate-limit"
]
% oc get --all-namespaces resourcequota -o json | jq '[.items[] | select((.metadata.namespace | startswith("openshift") | not) and (.metadata.namespace | startswith("kube-") | not) and .metadata.namespace != "default" and .metadata.namespace != "rhacs-operator" and (true)) | .metadata.namespace] | unique'
[
  "foo",
  "test-no-rate-limit"
]

[xiaojiey]

lgtm

[Vincent056]

/test 4.15-e2e-aws-ocp4-stig
/test 4.16-e2e-aws-ocp4-stig
/test 4.17-e2e-aws-ocp4-stig

[openshift-ci]

@Vincent056: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/4.17-e2e-aws-ocp4-stig	7a57333	link	true	/test 4.17-e2e-aws-ocp4-stig

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yuumasato]

Thank you @Vincent056