Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print assertion phase when verifying rule result #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yuumasato
Copy link
Member

When a rule's result doesn't match the expected result, let's also print the phase in which it happened, whether the default result or after remediation is applied.

When a rule's result doesn't match the expected result, let's also print
the phase in which it happened, whether the default result or after
remediation is applied.
@yuumasato
Copy link
Member Author

This is just a small quality of life improvement.

When I'm checking out the e2e results I search for to the rule didn't match lines and consistently find myself scrolling up or down to figure out whether the scan I'm looking at is the before or after remediations...

Copy link

openshift-ci bot commented Sep 16, 2024

@yuumasato: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp4-moderate cb2f055 link true /test e2e-aws-ocp4-moderate

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yuumasato
Copy link
Member Author

The moderate test failed, but that showcased the patch in action.

medium
    helpers.go:879: E2E-FAILURE: The expected remediated result for the e2e-moderate-resource-requests-limits-in-deployment rule didn't match. Expected 'PASS', Got 'FAIL'
    helpers.go:872: Result - Name: e2e-moderate-resource-requests-limits-in-statefulset - Status: FAIL - Severity: medium
    helpers.go:879: E2E-FAILURE: The expected remediated result for the e2e-moderate-resource-requests-limits-in-statefulset rule didn't match. Expected 'PASS', Got 'FAIL' 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant