Use correct device number #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
added
component: PMacc
|
This bug affects the master. Do to the reason that it only write out wrong device properties but not influence any other points a back port is not needed. |
|
@psychocoderHPC I still would recommend a backport as it is a 1-line fix which is unlikely to cause problems and the bug can lead to confusion. Consider someone publishing some results saying he used THIS accelerator but actually another one was used... |
|
that's ok, I'll cherry-pick it in the |
|
causes some merge conflicts, but I'll put it in and won't merge them on master to avoid conflicts. |
ax3l
added a commit
to ax3l/picongpu
that referenced
this pull request
Sep 17, 2015
…e ID Corrects the mapping of device when querying their properties.
psychocoderHPC
added a commit
that referenced
this pull request
Sep 17, 2015
Use correct device number
psychocoderHPC
added a commit
that referenced
this pull request
Sep 17, 2015
[BP] #1115: Correct Device ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrong device ID was used in the request