added catch for intro members w/o profile in nav #345
Conversation
|
Hey Matt! Thank you for making a PR to help packet! I think you are on the right track for this, but I think a more robust and neat solution would be pulling the Gravatar of the specific user logged in. The profile picture will work fine for all upperclassmen since we have accounts, so you'd need to find a way to identify its not an upperclassmen (there should be a util somewhere in here) and then get from gravatar like how the images do for your packet itself. If you need more clarification, please lmk! |
|
Thank you for your feedback, I've never used HTML logic so I'm not sure if this would work but hopefully this is a better solution |
|
I'll run a test later. You should totally come to floor later today! I don't remember if I've met you in person yet! |
while logic was in place to handle intro members without accounts on profiles.csh.rit.edu in the body there is none for the navbar. This is a potential fix. catches errors and directs them to the null@csh.rit.edu default profile picture
current behavior for intro member:
