Redirect to the configured host before OIDC if incorrect #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galenguyer
force-pushed
the
host-redirect
branch
from
60987e2 to
bbc559d
Compare
devinmatte
approved these changes
Aug 25, 2022
galenguyer
force-pushed
the
host-redirect
branch
from
bbc559d to
c12d91a
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If people go to freshman-packet.csh, SSO redirects them to freshmen-packet.csh, as it should, but this means Flask isn't aware of the previous session, leading to a lot of
{"error": "unsolicited_response", "error_description": "No initialised user session."}`. This checks that we're on the configured host before the request proceeds, and redirects to the configured host if we're not.