Repair build scripts to output an es5-compatible module #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgoldrbx
commented
Nov 9, 2018
| /npm-debug.log | ||
| .nyc_output | ||
| coverage | ||
| dist |
There was a problem hiding this comment.
added dist and normalized line endings to LF
pgoldrbx
commented
Nov 9, 2018
| ### Fixed | ||
| - Repair build scripts to output an es5-compatible module | ||
|
|
||
| ## Version 1.0.0 - 2018-10-09 |
There was a problem hiding this comment.
the 1.0.0 release wasn't added to the changelog. I'll clean this up further in a release commit.
pgoldrbx
commented
Nov 9, 2018
| const utils = require('./utils'); | ||
| const dom = require('./dom'); | ||
| const html = require('./html'); | ||
| Object.assign(module.exports, utils, dom, html); |
There was a problem hiding this comment.
moved here from root directory, to ensure all code passes through babel
pgoldrbx
commented
Nov 9, 2018
| "files": [ | ||
| "*.md", | ||
| "dist" | ||
| ], |
There was a problem hiding this comment.
limit the files published with the package
gazs
approved these changes
Nov 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I did not realize that the original maintainer had updated the repo to use es6 syntax but incorrectly implemented the build scripts. As a result, version 1.0.0 was not es5-compatible and this resulted in errors when used in webpack with uglify.
I've fixed the build scripts and did a bit of other cleanup.
Types of changes
Related Issue
Version 1.0.0 was added to to jsonmltoreact in CondeNast/jsonmltoreact#16. This led to build errors when trying to update in https://github.com/conde-nast-international/voguede-autopilot/pull/3165
Motivation and Context
1.0.0 was an unintentionally breaking change due to syntax incompatibility.
How Has This Been Tested?
I have not added any additional testing to verify that
babelworks as expected. If desired, I could add adisttest that runs the build and then passes the result throughuglify-js. However, I don't feel that's really necessary.Screenshots (if appropriate):
n/a
Checklist: