Defer to WordPress for URLs instead of trying to guess them #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmcev106
changed the title
|
An interesting solution. It would eliminate the |
shadoath
reviewed
May 10, 2021
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
|
I committed your suggestion to support parent themes. Do you have any other concerns we should consider before merging? I have NOT fully tested this PR. I was hoping you might have a test process that would be easy to run through... |
|
This repo does not yet have a good testing process to run through. I'm going to merge and pull it into some of my personal WP sites to test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into another URL issue when an alternate core directory is used. I think perhaps we should defer to WordPress for all base URLs, instead of having our own logic to generate them, since it seems to be difficult to cover all edge cases. What do you think of this approach?