Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compile() from outside the plugin #190

Merged
merged 7 commits into from
May 18, 2021

Conversation

niaccurshi
Copy link
Contributor

Cleaned up the class-wp-scss.php file primarily to allow for multiple instances of the Wp_Scss class without conflict with internal variables.

Removed almost all global variable references to create a more class based/object oriented structure, including removing direct calls to public class variables and replacing with function calls to retrieve private variables.

Lee Griffin added 2 commits May 13, 2021 01:46
Cleaned up the class-wp-scss.php file primarily to allow for multiple instances of the Wp_Scss class without conflict with internal variables. Removed almost all global variable references to create a more class based/object oriented structure, including removing direct calls to public class variables and replacing with function calls to retrieve private variables.
@shadoath shadoath self-requested a review May 13, 2021 13:24
Copy link
Collaborator

@shadoath shadoath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good work on this. Thank you for the clean-up as well as the added functionality. I added some minor code styling requests (I think these may have been around before your changes but I'm only seeing them now).

$this->scss_dir = $scss_dir;
$this->css_dir = $css_dir;
$this->compile_method = $compile_method;
$this->compile_errors = array();
$scssc = new Compiler();
$this->scssc = new Compiler();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please match the indent of the = sign with the line above for better code readablity.

class/class-wp-scss.php Outdated Show resolved Hide resolved
class/class-wp-scss.php Outdated Show resolved Hide resolved
class/class-wp-scss.php Outdated Show resolved Hide resolved
wp-scss.php Outdated Show resolved Hide resolved
niaccurshi and others added 5 commits May 18, 2021 13:44
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
Co-authored-by: Skylar Bolton <skylar.bolton@gmail.com>
@niaccurshi
Copy link
Contributor Author

Thanks, some of them may well have been me, either way I've committed those changes.

@shadoath
Copy link
Collaborator

Resolves #182

@shadoath shadoath merged commit e1d4950 into ConnectThink:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants