Fix always recompile bug #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added brackets around the ternary operator to ensure the logic still functions. Previously would return false even if WP_SCSS_ALWAYS_RECOMPILE was defined and true.
|
@shadoath Any updates on this? This is a very important update to make sure all the features work and it is backwards compatible. Thanks! |
shadoath
approved these changes
Aug 12, 2021
|
Missed seeing this PR come in. Thank you for the ping on this. I'll do a
version bump shortly and push that out too WP.
…On Thu, Aug 12, 2021, 04:45 Freddy Ochner ***@***.***> wrote:
@shadoath <https://github.com/shadoath> Any updates on this?
This is a very important update to make sure all the features work and it
is backwards compatible.
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO3DJHFMY3HUQQIL2SDP4LT4OCZDANCNFSM462OHANQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
|
@FreddyFY you can now pull the master branch and use it on your WP website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added brackets around the ternary operator to ensure the logic still functions. Previously would return false even if WP_SCSS_ALWAYS_RECOMPILE was defined and true.