Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored page resource, added ancestors key #135

Merged

Conversation

appsol
Copy link

@appsol appsol commented May 7, 2024

Summary

https://app.shortcut.com/connectedplaces/story/4090/add-in-breadcrumbs-data-to-api-endpoint-for-pages-slug

  • Refactored PageResource
  • Reduced size of relationship entities parent, landing_page and children
  • Added new relationship ancestors with a list of ancestors in descending order from root down suitable for breadcrumbs
  • Added new include=ancestors option for the pages index api to include the ancestors relationship on all page result items

Development checklist

  • Changes have been made to the API?
    • If so, the OpenAPI specification has been updated
  • Database migrations have been added?
    • If so, the MySQL Workbench ERD has been updated
  • The code has been linted ./develop composer fix:style

Release checklist

If there are any actions that must be performed as part of the release, then
create a checklist for them here.

Notes

If there are any further notes about the PR then write them here.

@appsol appsol merged commit fdf02eb into develop May 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant