Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon fixes #427

Merged
merged 6 commits into from
Nov 20, 2019
Merged

Icon fixes #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ad7e2b7
Merge pull request #425 from ConsenSys/development
gesquinca Nov 20, 2019
8ff69ec
updated changelog
gesquinca Nov 20, 2019
ec264b7
version bump
gesquinca Nov 20, 2019
972a59f
updated Icon component
gesquinca Nov 20, 2019
631fe93
updated examples for testing
gesquinca Nov 20, 2019
d769f76
udpated snapshot tests
gesquinca Nov 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,28 @@ class Example extends Component {

## Change log

### 0.11.0

🚀 New Feature
- Added `BaseStyles` component

🐛 Bug Fix
- Updated `Text` component to pass `as` prop correctly.
- Updated `Heading` component to pass `as` prop correctly.
- Updated `Select` component to adjust width.
- Updated `Field` to inherit color.
- Updated `Radio` and `Checkbox` components to inherit text and icon colors correctly.
- Fixed `pre-commit deprecation warning` #372.
- Fixed warnings when building library #376.

💅 Enhancement
- Adjusted `EthAddress` component padding.
- Addeded default font sizes for `h1-h6` elements.
- Styled `input[type="color"]` for better visibility.
- Updated default props for `Input`, `Textarea`, `Card`.
- Removed `copyColor` from `theme.js`.
- Added `text` and `background` colors to `theme.js`.

### 0.10.0

- Fixed Select arrow display bug.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "rimble-ui",
"version": "0.10.0",
"version": "0.11.0",
"description": "Rimble Design System react component library.",
"author": "ConsenSys Design",
"homepage": "https://rimble.consensys.design/",
Expand Down
75 changes: 65 additions & 10 deletions src/Button/__snapshots__/Button.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`Button Icon component sanity matches default snapshot 1`] = `
.c1 {
display: -webkit-inline-box;
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
}

.c1 {
box-sizing: border-box;
}

.c0 {
color: #fff;
background-color: #999;
Expand Down Expand Up @@ -142,11 +153,11 @@ exports[`Button Icon component sanity matches default snapshot 1`] = `
height="3rem"
>
<div
class=""
class="c1"
display="inline-flex"
>
<svg
class=""
display="block"
fill="currentcolor"
height="24px"
viewBox="0 0 24 24"
Expand All @@ -161,6 +172,17 @@ exports[`Button Icon component sanity matches default snapshot 1`] = `
`;

exports[`Button Icon component sanity matches themed snapshot 1`] = `
.c1 {
display: -webkit-inline-box;
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
}

.c1 {
box-sizing: border-box;
}

.c0 {
color: #fff;
background-color: #999;
Expand Down Expand Up @@ -302,11 +324,11 @@ exports[`Button Icon component sanity matches themed snapshot 1`] = `
height="3rem"
>
<div
class=""
class="c1"
display="inline-flex"
>
<svg
class=""
display="block"
fill="currentcolor"
height="24px"
viewBox="0 0 24 24"
Expand All @@ -321,6 +343,17 @@ exports[`Button Icon component sanity matches themed snapshot 1`] = `
`;

exports[`Button Icon only component sanity matches default snapshot 1`] = `
.c1 {
display: -webkit-inline-box;
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
}

.c1 {
box-sizing: border-box;
}

.c0 {
color: #fff;
background-color: #999;
Expand Down Expand Up @@ -463,11 +496,11 @@ exports[`Button Icon only component sanity matches default snapshot 1`] = `
height="3rem"
>
<div
class=""
class="c1"
display="inline-flex"
>
<svg
class=""
display="block"
fill="currentcolor"
height="24px"
viewBox="0 0 24 24"
Expand All @@ -482,6 +515,17 @@ exports[`Button Icon only component sanity matches default snapshot 1`] = `
`;

exports[`Button Icon with position prop component sanity matches default snapshot 1`] = `
.c1 {
display: -webkit-inline-box;
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
}

.c1 {
box-sizing: border-box;
}

.c0 {
color: #fff;
background-color: #999;
Expand Down Expand Up @@ -623,11 +667,11 @@ exports[`Button Icon with position prop component sanity matches default snapsho
height="3rem"
>
<div
class=""
class="c1"
display="inline-flex"
>
<svg
class=""
display="block"
fill="currentcolor"
height="24px"
viewBox="0 0 24 24"
Expand Down Expand Up @@ -2996,6 +3040,17 @@ exports[`Loading Button component sanity matches default snapshot 1`] = `
`;

exports[`Loading Button component sanity matches default snapshot 2`] = `
.c1 {
display: -webkit-inline-box;
display: -webkit-inline-flex;
display: -ms-inline-flexbox;
display: inline-flex;
}

.c1 {
box-sizing: border-box;
}

.c0 {
color: #fff;
background-color: #999;
Expand Down Expand Up @@ -3138,11 +3193,11 @@ exports[`Loading Button component sanity matches default snapshot 2`] = `
height="3rem"
>
<div
class=""
class="c1"
display="inline-flex"
>
<svg
class=""
display="block"
fill="currentcolor"
height="24px"
viewBox="0 0 24 24"
Expand Down
Loading