Directory storage engine; Switch to cryptonite base conversion functions #38
Conversation
…ddition of the 'dir' engine
…equirement is Quorum-specific
Constellation/Node/Storage/Sqlite.hs
Outdated
| -- [] -> Left "load: No payload found" | ||
| -- _ -> Left "load: More than one payload found" | ||
| -- TODO: In testStorage, don't rely on the presence of the strings below | ||
| [] -> Left "Key not found in SQLite" |
There was a problem hiding this comment.
@patrickmn actually I was thinking of changing the error text for all of the storage types to "payload not found" as you originally had here, since users seem to be confusing "key" with "private/public key".
| storage <- case break (== ':') cfgStorage of | ||
| ("bdb", ':':s) -> berkeleyDbStorage s | ||
| ("dir", ':':s) -> directoryStorage s | ||
| _ -> berkeleyDbStorage cfgStorage -- Default | ||
| -- storage <- memoryStorage |
There was a problem hiding this comment.
Is there any reason not to include this as an option for users with the new command line options?
There was a problem hiding this comment.
Command line options are parsed to create the cfg, so --storage "dir:..." would trigger this
There was a problem hiding this comment.
Sorry, I was referring to the memoryStorage option, not directoryStorage
There was a problem hiding this comment.
I have another PR coming which will enable that and others, just trying to decide if making leveldb a base dependency is worth it.
There was a problem hiding this comment.
I think it's worth having for now, until a final decision is made wrt storage to use - that way you don't have to have the commented out tests and dependencies in the code.
There was a problem hiding this comment.
Yeah was leaning the same way. Will open another PR soon, including some benchmarking code as well...
Adds a
dirstorage engine, specificable with--storage=dir:path. Constellation will create a file for each payload inpath/payloads. Important to note is that payload filenames will be Base32-encoded to ensure compatibility with case-insensitive file systems. (The API uses Base64 everywhere else.)This is intended to be useful for any storage engine that has a FUSE connector. Please note that if the file system is distributed, a payload must be readable by other nodes immediately after it has been written (at least if used with Quorum.)
Changes wording for storage backend error messages when a payload isn't found from "key not found" to "payload not found"
Simplifies some of the ByteArray Base64 conversion stuff.