remove support for GoQuorum private transactions via Besu

CHANGELOG.md

@@ -5,6 +5,9 @@
 ### Bugs Fixed
 - Update of Azure libraries (transitive via signers library) and manual override to fix CVE-2023-1370
 
+### Breaking Changes
+- remove support for GoQuorum private transactions via Besu [#500](https://github.com/ConsenSys/ethsigner/pull/500)
+
 ---
 
 ## 23.2.0

ethsigner/core/src/main/java/tech/pegasys/ethsigner/core/requesthandler/sendtransaction/SendTransactionHandler.java

@@ -22,10 +22,8 @@
 import tech.pegasys.ethsigner.core.jsonrpc.exception.JsonRpcException;
 import tech.pegasys.ethsigner.core.requesthandler.JsonRpcRequestHandler;
 import tech.pegasys.ethsigner.core.requesthandler.VertxRequestTransmitterFactory;
-import tech.pegasys.ethsigner.core.requesthandler.sendtransaction.transaction.GoQuorumPrivateTransaction;
 import tech.pegasys.ethsigner.core.requesthandler.sendtransaction.transaction.Transaction;
 import tech.pegasys.ethsigner.core.requesthandler.sendtransaction.transaction.TransactionFactory;
-import tech.pegasys.ethsigner.core.signing.GoQuorumPrivateTransactionSerializer;
 import tech.pegasys.ethsigner.core.signing.TransactionSerializer;
 import tech.pegasys.signers.secp256k1.api.Signer;
 
@@ -97,10 +95,7 @@ private void sendTransaction(
       final Signer signer,
       final JsonRpcRequest request) {
 
-    final TransactionSerializer transactionSerializer =
-        transaction instanceof GoQuorumPrivateTransaction
-            ? new GoQuorumPrivateTransactionSerializer(signer, chainId)
-            : new TransactionSerializer(signer, chainId);
+    final TransactionSerializer transactionSerializer = new TransactionSerializer(signer, chainId);
 
     final TransactionTransmitter transmitter =
         createTransactionTransmitter(transaction, transactionSerializer, routingContext, request);

ethsigner/core/src/main/java/tech/pegasys/ethsigner/core/requesthandler/sendtransaction/transaction/TransactionFactory.java

@@ -23,13 +23,9 @@
 
 import io.vertx.core.json.JsonObject;
 import io.vertx.ext.web.RoutingContext;
-import org.apache.logging.log4j.LogManager;
-import org.apache.logging.log4j.Logger;
 
 public class TransactionFactory {
 
-  private static final Logger LOG = LogManager.getLogger();
-
   private final VertxRequestTransmitterFactory transmitterFactory;
   private final JsonDecoder decoder;
 
@@ -43,13 +39,10 @@ public Transaction createTransaction(final RoutingContext context, final JsonRpc
     final String method = request.getMethod().toLowerCase();
     final VertxNonceRequestTransmitter nonceRequestTransmitter =
         new VertxNonceRequestTransmitter(context.request().headers(), decoder, transmitterFactory);
-    final VertxStoreRawRequestTransmitter storeRawRequestTransmitter =
-        new VertxStoreRawRequestTransmitter(
-            context.request().headers(), decoder, transmitterFactory);
 
     switch (method) {
       case "eth_sendtransaction":
-        return createEthTransaction(request, nonceRequestTransmitter, storeRawRequestTransmitter);
+        return createEthTransaction(request, nonceRequestTransmitter);
       case "eea_sendtransaction":
         return createEeaTransaction(request, nonceRequestTransmitter);
       default:
@@ -58,20 +51,16 @@ public Transaction createTransaction(final RoutingContext context, final JsonRpc
   }
 
   private Transaction createEthTransaction(
-      final JsonRpcRequest request,
-      final VertxNonceRequestTransmitter nonceRequestTransmitter,
-      final VertxStoreRawRequestTransmitter storeRawRequestTransmitter) {
+      final JsonRpcRequest request, final VertxNonceRequestTransmitter nonceRequestTransmitter) {
     final EthSendTransactionJsonParameters params =
         fromRpcRequestToJsonParam(EthSendTransactionJsonParameters.class, request);
 
     final NonceProvider ethNonceProvider =
         new EthNonceProvider(params.sender(), nonceRequestTransmitter);
-    final StoreRawEnclaveLookupIdProvider lookupIdProvider =
-        new StoreRawEnclaveLookupIdProvider(storeRawRequestTransmitter);
 
     if (params.privateFor().isPresent()) {
-      return GoQuorumPrivateTransaction.from(
-          params, ethNonceProvider, lookupIdProvider, request.getId());
+      throw new IllegalArgumentException(
+          "GoQuorum private transactions (using PrivateFor) are not supported.");
     } else {
       return new EthTransaction(params, ethNonceProvider, request.getId());
     }
@@ -83,14 +72,6 @@ private Transaction createEeaTransaction(
     final EeaSendTransactionJsonParameters params =
         fromRpcRequestToJsonParam(EeaSendTransactionJsonParameters.class, request);
 
-    if (params.privacyGroupId().isPresent() == params.privateFor().isPresent()) {
-      LOG.warn(
-          "Illegal private transaction received; privacyGroup (present = {}) and privateFor (present = {}) are mutually exclusive.",
-          params.privacyGroupId().isPresent(),
-          params.privateFor().isPresent());
-      throw new IllegalArgumentException("PrivacyGroup and PrivateFor are mutually exclusive.");
-    }
-
     if (params.privacyGroupId().isPresent()) {
       final NonceProvider nonceProvider =
           new BesuPrivateNonceProvider(