Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
leastauthority pointed out that the sumcheck package incorrectly yields
negFactorial(1) = 1
(should be -1)This PR puts the correct implementation from the polynomial package in internal to be used by both.
Update:
The incorrect version of
negFactorial
was used byInterpolateInRange
which itself wasn't used anywhere.negFactorial
is back inpolynomial.go
andInterpolateInRange
is deleted.Type of change
Tests
Checklist:
golangci-lint
does not output errors locally