Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: describe potential length extension attack when using MiMC in-circuit #1198

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

ivokub
Copy link
Collaborator

@ivokub ivokub commented Jul 11, 2024

Description

Certain use cases of MiMC may lead to length extension attacks. Document these cases to help the users avoid them.

This will follow up with a PR on gnark-crypto to give the same considerations.

Fixes #1141

Type of change

  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ivokub ivokub merged commit 8c1cd75 into master Jul 12, 2024
7 checks passed
@ivokub ivokub deleted the docs/mimc-length-extension branch July 12, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants