Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump gnark-crypto version and match interface changes #1251

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Aug 16, 2024

This PR updates the Groth16 BSB22 Commitments module to match recent gnark-crypto changes.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tabaie Tabaie requested a review from yelhousni August 16, 2024 18:17
@Tabaie Tabaie marked this pull request as ready for review August 17, 2024 17:44
Copy link
Contributor

@yelhousni yelhousni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yelhousni yelhousni merged commit 841a46e into master Aug 20, 2024
7 checks passed
@yelhousni yelhousni deleted the build/bump-gnarkcrypto-vsn branch August 20, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants