Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat test engine friendly GKR #1253

Merged
merged 2 commits into from
Aug 21, 2024
Merged

feat test engine friendly GKR #1253

merged 2 commits into from
Aug 21, 2024

Conversation

Tabaie
Copy link
Contributor

@Tabaie Tabaie commented Aug 21, 2024

Currently, GKR cannot run under the test engine. This PR changes that by implementing hints that delegate to the appropriate curve-specific ones used in the solver.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@Tabaie Tabaie requested review from gbotrel and ivokub August 21, 2024 01:19
@Tabaie Tabaie merged commit f969f1f into master Aug 21, 2024
7 checks passed
@Tabaie Tabaie deleted the feat/gkr-hints branch August 21, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants