Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): Outstanding Issues in Multi-Chain Feature for SDK #748

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore(sdk): Outstanding Issues in Multi-Chain Feature for SDK #748

merged 1 commit into from
Oct 17, 2024

Conversation

alainncls
Copy link
Collaborator

@alainncls alainncls commented Oct 14, 2024 •
edited
Loading

What does this PR do?

Makes the Verax SDK compatible with frontends in multichain mode:

  • Fixed the resolvers import
  • Overrides incompatible dependencies
  • Overrides the use of process.env to make sure it's not an issue in frontend

Related ticket

Fixes #746

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Oct 14, 2024
@alainncls alainncls force-pushed the chore/outstanding-issues-in-multi-chain-feature-for-sdk branch from 80affa1 to afabcfa Compare October 14, 2024 14:53
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

🚀 Deployed on https://671124d9657e76509868f2d8--resilient-starburst-d5d6d9.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 14, 2024 14:54 Inactive
@alainncls alainncls force-pushed the chore/outstanding-issues-in-multi-chain-feature-for-sdk branch from afabcfa to 6c866fc Compare October 17, 2024 14:52
@github-actions github-actions bot temporarily deployed to pull request October 17, 2024 14:53 Inactive
@alainncls alainncls marked this pull request as ready for review October 17, 2024 16:15
@alainncls alainncls merged commit ecd082a into feat/multichain Oct 17, 2024
10 checks passed
@alainncls alainncls deleted the chore/outstanding-issues-in-multi-chain-feature-for-sdk branch October 17, 2024 20:39
alainncls added a commit that referenced this pull request Oct 29, 2024
@alainncls
chore(sdk): Outstanding Issues in Multi-Chain Feature for SDK (#748)
e53be26
alainncls added a commit that referenced this pull request Nov 28, 2024
@alainncls
chore(sdk): Outstanding Issues in Multi-Chain Feature for SDK (#748)
198e087
alainncls added a commit that referenced this pull request Dec 6, 2024
@alainncls
chore(sdk): Outstanding Issues in Multi-Chain Feature for SDK (#748)
6e23be7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orbmis orbmis orbmis approved these changes

@satyajeetkolhapure satyajeetkolhapure Awaiting requested review from satyajeetkolhapure satyajeetkolhapure is a code owner

@arthur-remy arthur-remy Awaiting requested review from arthur-remy arthur-remy is a code owner

@ars9 ars9 Awaiting requested review from ars9

@Solniechniy Solniechniy Awaiting requested review from Solniechniy

Assignees

@alainncls alainncls

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alainncls @orbmis