Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA - Only publish docker builds on main branch #200

Merged
merged 53 commits into from
Oct 24, 2024
Merged

GHA - Only publish docker builds on main branch #200

merged 53 commits into from
Oct 24, 2024

Conversation

bradbown
Copy link
Contributor

This PR implements issue(s) #181

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@bradbown bradbown temporarily deployed to docker-build-and-e2e October 16, 2024 20:10 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.11%. Comparing base (e71ec80) to head (08294d2).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #200      +/-   ##
============================================
- Coverage     71.39%   69.11%   -2.28%     
  Complexity     1077     1077              
============================================
  Files           298      264      -34     
  Lines         12038    11130     -908     
  Branches       1073      914     -159     
============================================
- Hits           8595     7693     -902     
+ Misses         2957     2952       -5     
+ Partials        486      485       -1
Flag Coverage Δ
hardhat ?
kotlin 69.11% <ø> (-0.06%) ⬇️

see 38 files with indirect coverage changes

@bradbown bradbown temporarily deployed to docker-build-and-e2e October 16, 2024 20:25 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 16, 2024 20:31 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 16, 2024 20:35 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 16, 2024 20:44 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 16, 2024 21:03 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 16, 2024 21:38 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 13:18 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 13:38 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 14:46 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 14:56 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 15:06 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 15:46 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 16:02 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 18:32 — with GitHub Actions Inactive
@bradbown bradbown temporarily deployed to docker-build-and-e2e October 17, 2024 18:59 — with GitHub Actions Inactive
@bradbown bradbown had a problem deploying to docker-build-and-e2e October 17, 2024 20:19 — with GitHub Actions Failure
@bradbown bradbown had a problem deploying to docker-build-and-e2e October 17, 2024 20:43 — with GitHub Actions Failure
@bradbown bradbown had a problem deploying to docker-build-and-e2e October 17, 2024 20:46 — with GitHub Actions Failure
@bradbown bradbown marked this pull request as ready for review October 17, 2024 20:47
@bradbown bradbown had a problem deploying to docker-build-and-e2e October 17, 2024 20:53 — with GitHub Actions Failure
@jonesho jonesho force-pushed the gha-publish-on-main branch from 2e0e3c8 to 821b842 Compare October 23, 2024 06:33
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 23, 2024 06:34 — with GitHub Actions Inactive
@jonesho jonesho requested a review from VGau October 23, 2024 09:53
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 23, 2024 10:35 — with GitHub Actions Inactive
@jonesho jonesho had a problem deploying to docker-build-and-e2e October 23, 2024 18:57 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 23, 2024 19:13 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 24, 2024 09:13 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e October 24, 2024 10:18 — with GitHub Actions Inactive
@jonesho jonesho merged commit 80e12cd into main Oct 24, 2024
29 checks passed
@jonesho jonesho deleted the gha-publish-on-main branch October 24, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesho jonesho jonesho left review comments

@VGau VGau VGau approved these changes

@jpnovais jpnovais Awaiting requested review from jpnovais

@Filter94 Filter94 Awaiting requested review from Filter94

Assignees

@jonesho jonesho

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bradbown @codecov-commenter @jpnovais @jonesho @VGau