Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prover/full recursion #350

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Prover/full recursion #350

wants to merge 27 commits into from

Conversation

AlexandreBelling
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling added the Prover Tag to use for all work impacting the prover label Nov 28, 2024
@AlexandreBelling AlexandreBelling self-assigned this Nov 28, 2024
arijitdutta67
arijitdutta67 previously approved these changes Dec 2, 2024
View reviewed changes
Soleimani193
Soleimani193 previously approved these changes Dec 2, 2024
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (4a7b76c) to head (e63a62e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #350      +/-   ##
============================================
+ Coverage     68.22%   70.38%   +2.16%     
+ Complexity     1128     1061      -67     
============================================
  Files           319      305      -14     
  Lines         12795    12201     -594     
  Branches       1277     1166     -111     
============================================
- Hits           8729     8588     -141     
+ Misses         3540     3141     -399     
+ Partials        526      472      -54
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 68.06% <ø> (+2.21%) ⬆️ Carriedforward from 29a64c5

*This pull request uses carry forward flags. Click here to find out more.

see 50 files with indirect coverage changes

AlexandreBelling
AlexandreBelling commented Dec 4, 2024
View reviewed changes
prover/crypto/fiatshamir/snark.go
@@ -52,6 +52,34 @@ func NewGnarkFiatShamir(api frontend.API, factory *gkrmimc.HasherFactory) *Gnark
}
}

// SetState mutates the fiat-shamir state of
func (fs *GnarkFiatShamir) SetState(state []frontend.Variable) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still to validate the API change on gnark side

AlexandreBelling
AlexandreBelling commented Dec 4, 2024
View reviewed changes
prover/protocol/column/store.go
@@ -44,6 +44,9 @@ type storedColumnInfo struct {
ID ifaces.ColID
// Status of the commitment
Status Status
// IncludeInProverFS states the prover should include the column in his FS
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, mention that this is meaningful for ignored columns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Soleimani193 Soleimani193 Soleimani193 left review comments

@arijitdutta67 arijitdutta67 arijitdutta67 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@AlexandreBelling AlexandreBelling

Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlexandreBelling @codecov-commenter @arijitdutta67 @Soleimani193