Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] - GASLIMIT opcode test #412

Merged
merged 14 commits into from
Dec 20, 2024
Merged

[Feat] - GASLIMIT opcode test #412

merged 14 commits into from
Dec 20, 2024

Conversation

kyzooghost
Copy link
Contributor

This PR implements #4035

  • Add GasLimitTestContract to test using GASLIMIT opcode and store it in storage
  • Add E2E test executing above contract

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost requested a review from a team as a code owner December 10, 2024 03:28
Signed-off-by: kyzooghost <73516204+kyzooghost@users.noreply.github.com>
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e December 10, 2024 03:33 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (ea79b2d) to head (d8843a6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #412   +/-   ##
=========================================
  Coverage     68.22%   68.22%           
  Complexity     1128     1128           
=========================================
  Files           319      319           
  Lines         12795    12795           
  Branches       1277     1277           
=========================================
  Hits           8729     8729           
  Misses         3540     3540           
  Partials        526      526           
Flag Coverage Δ
hardhat 98.70% <ø> (ø)
kotlin 65.84% <ø> (ø)

@kyzooghost kyzooghost requested a review from jonesho December 10, 2024 04:41
Copy link
Collaborator

@thedarkjester thedarkjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my only other comment is that we will probably expect to test other opcodes and this contract could be positioned/later extended as an "opcode" testing contract vs. just gasLimit - it might be prudent to name it that way so that anyone can use it for next steps

e2e/src/gas-limit.spec.ts Outdated Show resolved Hide resolved
@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e December 20, 2024 10:08 — with GitHub Actions Inactive
@kyzooghost kyzooghost merged commit 4a7b76c into main Dec 20, 2024
25 checks passed
@kyzooghost kyzooghost deleted the feat/gaslimit-test branch December 20, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants