-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] - GASLIMIT opcode test #412
Conversation
Signed-off-by: kyzooghost <73516204+kyzooghost@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #412 +/- ##
=========================================
Coverage 68.22% 68.22%
Complexity 1128 1128
=========================================
Files 319 319
Lines 12795 12795
Branches 1277 1277
=========================================
Hits 8729 8729
Misses 3540 3540
Partials 526 526
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my only other comment is that we will probably expect to test other opcodes and this contract could be positioned/later extended as an "opcode" testing contract vs. just gasLimit - it might be prudent to name it that way so that anyone can use it for next steps
This PR implements #4035
Checklist