-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#461 Prover: Add constraints version validation #470
Conversation
I think you can exclude |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
=========================================
Coverage 68.17% 68.18%
Complexity 1125 1125
=========================================
Files 319 319
Lines 12789 12789
Branches 1275 1275
=========================================
+ Hits 8719 8720 +1
+ Misses 3542 3541 -1
Partials 528 528
*This pull request uses carry forward flags. Click here to find out more. |
You can change the title of this PR to something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
UPDATE: @gusiri @AlexandreBelling Reworking this PR as e2e tests are failing due to the absence of |
359b02d
ac6a3b6
Ok, previous e2e test was failing because apparently the conflated trace file can contain optional dir path For eg: |
This PR implements issue(s) #
zkevm/arithmetization/zkevm.bin
to extract the version from the git branch in the constraints repo and creates aconstraints-versions.txt
file. This approach relies on branch naming conventions as the linea-constraints repo does not support tags for every release. Tags with version names for every release are recommended to reliably extract versions from tags instead of branches.constraints-versions.txt
file.dev
mode.