Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Upgrade] Go-Ethereum release v1.9.13 #1123

Merged
merged 125 commits into from
Feb 12, 2021

Conversation

ricardolyn
Copy link
Contributor

@ricardolyn ricardolyn commented Feb 4, 2021

TODO

Plan & Analyse

  • Review the Release Notes
  • Review PRs in the section below

As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.

Build & Test

  • Pull and checkout PR branch locally, then merge GoQuorum master into this branch
  • Resolve conflicts, taking into account the prior analysis
  • Implement required changes until all unit tests pass
  • Implement required changes until acceptance tests pass
  • Implement extra changes and/or tests

Extra Changes & Tests

// Ensure to Disable HTTP/2
		// this configuration and customized tls.Config is to follow: https://blog.bracebin.com/achieving-perfect-ssl-labs-score-with-go
		TLSNextProto: make(map[string]func(*http.Server, *tls.Conn, http.Handler)),

Go-Ethereum Release: Drossix Blue (v1.9.13)

  • Version: v1.9.13
  • Published: 2020-04-16T07:43:17Z

Release notes

Geth v1.9.13 is a scheduled maintenance release, focusing on polishes and fixes. The highlight of the release is that we've finally merged support for dynamic state snapshots, something we've been working on for over half a year. For now it's not yet enabled by default, but we're hoping for big things to be built on top of this.

This release also switches over to Go 1.14.2 (the first version in the 1.14.x family that is stable for Ethereum), resulting in about 10% block processing speedup.

A summary of the features we've been working on:

  • Implement dynamic state snapshots (behind --snapshot for now) (#20152).
  • Bump the propagated transaction size limit to 128KB, up from 64KB (#20835).
  • Support running the HTTP and WebSocket RPC on the same port (#20810).
  • Support keeping the ethash caches and DAG forcefully in RAM (#20484).
  • Deprecate --testnet in favor of --ropsten, but keep it for now (#20852).
  • Add a newaccount command to Clef, mostly for tutorial purposes (#20782).
  • Expose individual metrics for every RPC method call type (#20847).
  • Add support for exposing/exporting metrics from geth import runs (#20738).
  • Add debug_accountRange RPC API to iterate over the accounts (#19645).
  • Write up the documentation for the checkpoint-admin command (#20697).
  • Change DNS discovery record TTLs to saner values (#20801, #20819, #20820).
  • General cleanups in the ecies crypto package used by RLPx(#20836).

And a summary of the bugs we've been fixing:

  • Improve node shutdown, avoiding a crash in fast sync (#20695).
  • Fix filtering for event topics consisting of negative integers (#20865).
  • Fix and clean up database iteration with prefixes and start keys (#20808).
  • Fix an issue in eth_call that changed the balance of the caller (#20783).
  • Fix a crash in initial fast sync when also mining at the same time (#20780).
  • Fix the RPC startup logs to display the actual port if requested 0 (#20789).
  • Fix a light client deadlock that caused the testnet faucets to freeze up (#20828).
  • Fix a data race in the ancient database between retrieval and shutdown (#20919).
  • Fix an annoying duktape build warning that many believed was an error (#20777).
  • Fix an iteration issue in rawdb tables that returned wrong keys (unused code) (#20703).
  • Fix an RPC regression in the clique namespace that broke default arguments (#20781).
  • Fix an annoyance that rejected --rpcapi=rpc (not that you would need to use this) (#20776).
  • Fix an iOS build issue caused by CPU metrics relying on an unavailable kernel header (#20816).

For a full rundown of the changes please consult the Geth 1.9.13 release milestone.


As with all our previous releases, you can find the:

Codebase changes assessment

Legend

File Stats: (A) Added, (M) Modified and (R) Removed

Line Stats: (A) Added and (R) Removed

Assessment:

  • ✅ No conflict expected
  • ⚠ Review required to assess changes
  • ‼️ Conflicts expected and review required

74 Pull Requests

🔍 Link Title File Stats
M/A/R
Packages changed
(files changed)
Line Stats
A/R
Top 5 Changed Files
(lines changed)
#20697 cmd/checkpoint-admin: add doc 0/1/0
cmd/checkpoint-admin (1)
103/0
cmd/checkpoint-admin/README.md (206)
‼️ #20777 go.mod: update gopkg.in/olebedev/go-duktape to fix sprintf warnings 2/0/0
go.mod (1)
go.sum (1)
3/1
go.mod (4)
go.sum (4)
#20703 core/rawdb: fix table database 1/1/0
core/rawdb (2)
216/3
core/rawdb/table_test.go (286)
core/rawdb/table.go (152)
‼️ #20780 eth: when triggering a sync, check the head header TD, not block 2/0/0
eth (2)
4/4
eth/handler.go (8)
eth/sync.go (8)
#20779 core/rawdb: fix freezer table test error check 1/0/0
core/rawdb (1)
2/4
core/rawdb/freezer_table_test.go (12)
‼️ #20781 internal/web3ext: fix clique console apis to work on missing arguments 1/0/0
internal/web3ext (1)
2/2
internal/web3ext/web3ext.go (8)
#20788 whisper/whisperv6: delete failing tests 0/0/1
whisper/whisperv6 (1)
0/548
whisper/whisperv6/peer_test.go (1096)
‼️ #20776 rpc: dont log an error if user configures --rpcapi=rpc... 1/0/0
rpc (1)
4/3
rpc/endpoints.go (14)
#20152 Dynamic state snapshots 15/15/0
core/state/snapshot (14)
core (4)
cmd/geth (3)
core/rawdb (3)
cmd/evm (2)
core/state (2)
accounts/abi/bind/backends (1)
cmd/utils (1)
5148/34
core/state/snapshot/iterator_test.go (1324)
core/state/snapshot/snapshot.go (1206)
core/state/snapshot/difflayer.go (1066)
core/blockchain_test.go (1046)
core/state/snapshot/disklayer_test.go (870)
‼️ #20798 core: simplify atomic store after writeBlockWithState 1/0/0
core (1)
1/2
core/blockchain.go (6)
‼️ #20789 node, cmd/clef: report actual port used for http rpc 2/0/0
cmd/clef (1)
node (1)
7/5
node/node.go (16)
cmd/clef/main.go (8)
‼️ #20783 internal/ethapi: don't set sender-balance to maxuint, fixes #16999 3/0/0
eth (1)
internal/ethapi (1)
les (1)
1/9
internal/ethapi/api.go (12)
eth/api_backend.go (4)
les/api_backend.go (4)
#20816 metrics: disable CPU stats (gosigar) on iOS 1/2/0
metrics (3)
54/12
metrics/cpu_enabled.go (62)
metrics/cpu_disabled.go (46)
metrics/cpu.go (24)
#20801 cmd/devp2p: tweak DNS TTLs 1/0/0
cmd/devp2p (1)
2/2
cmd/devp2p/dnscmd.go (8)
#20819 cmd/devp2p: lower route53 change limit again 1/0/0
cmd/devp2p (1)
5/3
cmd/devp2p/dns_route53.go (16)
#20820 cmd/devp2p: be very correct about route53 change splitting 2/0/0
cmd/devp2p (2)
43/14
cmd/devp2p/dns_route53.go (82)
cmd/devp2p/dns_route53_test.go (32)
#20824 graphql, node, rpc: fix typos in comments 5/0/0
rpc (3)
graphql (1)
node (1)
8/9
node/node.go (12)
rpc/http.go (8)
rpc/subscription.go (8)
graphql/service.go (4)
rpc/endpoints.go (2)
#20695 eth: improve shutdown synchronization 8/0/0
eth (7)
core (1)
213/138
eth/sync.go (364)
eth/handler.go (190)
eth/backend.go (88)
eth/helper_test.go (30)
eth/sync_test.go (18)
#20828 les: fix dead lock 1/0/0
les (1)
1/2
les/peer.go (6)
⚠️ #20827 eth/filters: fix typo on unindexedLogs function's comment 1/0/0
eth/filters (1)
1/1
eth/filters/filter.go (4)
‼️ #20835 core: bump txpool tx max size to 128KB 1/0/0
core (1)
1/1
core/tx_pool.go (4)
⚠️ #20812 snapshotter/tests: verify snapdb post-state against trie 2/1/0
core (1)
core/state/snapshot (1)
tests (1)
137/0
core/state/snapshot/conversion.go (228)
tests/block_test_util.go (28)
core/blockchain.go (18)
⚠️ #20484 cmd, consensus: add option to disable mmap for DAG caches/datasets 8/0/0
cmd/geth (3)
consensus/ethash (2)
eth (2)
cmd/utils (1)
108/48
consensus/ethash/ethash.go (118)
cmd/utils/flags.go (56)
consensus/ethash/algorithm_test.go (54)
eth/backend.go (28)
cmd/geth/retesteth.go (24)
#20782 cmd/clef: add newaccount command 4/0/0
cmd/clef (2)
signer/core (2)
78/5
cmd/clef/main.go (96)
signer/core/api.go (28)
cmd/clef/intapi_changelog.md (22)
signer/core/uiapi.go (20)
#19645 eth: add debug_accountRange API 3/0/0
eth (2)
core/state (1)
102/132
eth/api_test.go (196)
eth/api.go (176)
core/state/dump.go (96)
‼️ #20833 travis: allow cocoapods deploy to fail 1/0/0
.travis.yml (1)
10/1
.travis.yml (22)
#20815 whisper/whisperv6: decrease pow requirement in tests 1/0/0
whisper/whisperv6 (1)
1/1
whisper/whisperv6/message_test.go (4)
#20818 metrics: make flawed test less flawed 1/0/0
metrics (1)
17/4
metrics/timer_test.go (42)
#20509 les: create utilities as common package 3/0/4
les/utils (4)
les (3)
90/90
les/utils/weighted_select.go (100)
les/serverpool.go (78)
les/utils/exec_queue.go (74)
les/utils/exec_queue_test.go (40)
les/peer.go (30)
‼️ #20841 Update readme genesis states with Istanbul and Muir Glacier 1/0/0
README.md (1)
2/1
README.md (6)
#20844 ``whisper fix whisper go routine leak with sync wait group`` 2/0/0
whisper/whisperv6 (2)
18/0
#20792 cmd/evm: Rework execution stats 1/0/0
cmd/evm (1)
24/22
cmd/evm/runner.go (92)
#20843 cmd/devp2p, cmd/wnode, whisper: add missing calls to Timer.Stop 3/0/0
cmd/devp2p (1)
cmd/wnode (1)
whisper/whisperv6 (1)
3/0
cmd/devp2p/crawl.go (2)
cmd/wnode/main.go (2)
whisper/whisperv6/whisper.go (2)
⚠️ #20846 p2p/server: add UDP port mapping goroutine to wait group 1/0/0
p2p (1)
5/1
p2p/server.go (12)
#20850 accounts/abi: faster unpacking of int256 2/0/0
accounts/abi (2)
10/14
accounts/abi/unpack.go (44)
accounts/abi/unpack_test.go (4)
#20853 p2p/discv5: add missing Timer.Stop calls 1/0/0
p2p/discv5 (1)
4/0
p2p/discv5/net.go (8)
⚠️ #20857 miner/worker: add missing timer.Stop call 1/0/0
miner (1)
1/0
miner/worker.go (2)
‼️ #20860 cmd/geth: fix bad genesis test 1/0/0
cmd/geth (1)
6/22
cmd/geth/genesis_test.go (56)
⚠️ #20862 eth/filters: add missing Ticker.Stop call 1/0/0
eth/filters (1)
1/0
eth/filters/api.go (2)
#20861 eth/fetcher: add missing timer.Stop calls 1/0/0
eth/fetcher (1)
2/0
eth/fetcher/block_fetcher.go (4)
#20864 les: add missing Ticker.Stop call 1/0/0
les (1)
1/0
les/costtracker.go (2)
#20868 event: add missing timer.Stop call in TestFeed 1/0/0
event (1)
1/0
event/feed_test.go (2)
#20866 metrics: add missing calls to Ticker.Stop in tests 2/0/0
metrics (2)
2/0
metrics/meter_test.go (2)
metrics/sample_test.go (2)
⚠️ #20867 ethstats: add missing Ticker.Stop call 1/0/0
ethstats (1)
1/0
ethstats/ethstats.go (2)
#20869 p2p/discv5, p2p/testing: add missing Timer.Stop calls in tests 2/0/0
p2p/discv5 (1)
p2p/testing (1)
3/1
p2p/discv5/sim_test.go (6)
p2p/testing/protocolsession.go (2)
⚠️ #20870 core: add missing Timer.Stop call in TestLogReorgs 1/0/0
core (1)
1/0
core/blockchain_test.go (2)
⚠️ #20863 rpc: add missing timer.Stop calls in websocket tests 1/0/0
rpc (1)
7/5
rpc/websocket_test.go (24)
#20836 crypto/ecies: improve concatKDF 3/0/0
crypto/ecies (3)
93/109
crypto/ecies/ecies.go (286)
crypto/ecies/ecies_test.go (80)
crypto/ecies/params.go (38)
#20847 rpc: add metrics for generic json rpc 1/1/0
rpc (2)
55/2
rpc/metrics.go (78)
rpc/handler.go (36)
#20888 mobile: remove duplicated code 1/0/0
mobile (1)
2/18
mobile/bind.go (40)
#20667 all: fix a bunch of inconsequential goroutine leaks 6/0/0
rpc (2)
miner (1)
common/prque (1)
console (1)
event (1)
123/106
console/console.go (170)
rpc/subscription_test.go (152)
miner/worker_test.go (86)
common/prque/lazyqueue_test.go (38)
rpc/client_test.go (10)
‼️ #20854 internal/ethapi: CallArgs.ToMessage method 1/0/0
internal/ethapi (1)
37/32
internal/ethapi/api.go (138)
#20897 les: fix flaky test 2/0/0
eth (1)
les (1)
2/2
eth/handler_test.go (4)
les/peer_test.go (4)
⚠️ #20738 cmd/geth: enable metrics for geth import command 1/0/0
cmd/geth (1)
13/0
cmd/geth/chaincmd.go (26)
⚠️ #20761 core/vm: use a callcontext struct 7/0/0
core/vm (6)
core/vm/runtime (1)
349/292
core/vm/instructions.go (1092)
core/vm/interpreter.go (56)
core/vm/runtime/runtime_test.go (56)
core/vm/instructions_test.go (32)
core/vm/intpool.go (22)
#20898 docs/audits: add disc v5 audits from LA and C53 0/2/0
docs/audits (2)
0/0
⚠️ #20896 .github: change gitter reference to discord link in issue template 1/0/0
.github (1)
1/1
.github/ISSUE_TEMPLATE.md (4)
#20900 cmd/clef/docs: couple of fixes to typos 1/0/0
cmd/clef/docs (1)
7/7
cmd/clef/docs/setup.md (28)
#20750 p2p/discover: add initial discovery v5 implementation 13/6/0
p2p/discover (13)
cmd/devp2p (4)
p2p/enode (2)
2970/74
p2p/discover/v5_udp.go (1664)
p2p/discover/v5_encoding.go (1318)
p2p/discover/v5_udp_test.go (1244)
p2p/discover/v5_encoding_test.go (746)
cmd/devp2p/discv5cmd.go (246)
#20901 build: upgrade to golangci-lint 1.24.0 8/0/0
build (2)
eth/downloader (1)
p2p/discv5 (1)
whisper/mailserver (1)
accounts/scwallet (1)
cmd/puppeth (1)
core (1)
42/34
build/checksums.txt (64)
eth/downloader/downloader_test.go (28)
core/tx_pool_test.go (16)
whisper/mailserver/mailserver.go (16)
accounts/scwallet/wallet.go (12)
#20891 whisper/mailserver : recover db file when openfile corrupted 1/0/0
whisper/mailserver (1)
4/0
whisper/mailserver/mailserver.go (8)
#20851 accounts/abi/bind: Refactored topics 4/0/0
accounts/abi (2)
accounts/abi/bind (2)
55/128
accounts/abi/bind/topics.go (314)
accounts/abi/bind/topics_test.go (32)
accounts/abi/unpack.go (16)
accounts/abi/argument.go (4)
⚠️ #20810 node: allow websocket and HTTP on the same port 9/3/1
node (6)
rpc (4)
graphql (1)
cmd/clef (1)
cmd/geth (1)
443/268
node/rpcstack.go (318)
node/endpoints.go (198)
rpc/http.go (194)
rpc/endpoints.go (166)
node/node.go (138)
#20718 crypto: improve error messages in LoadECDSA 3/0/0
crypto (2)
cmd/geth (1)
143/29
crypto/crypto_test.go (170)
crypto/crypto.go (112)
cmd/geth/accountcmd_test.go (62)
#20904 node: changed date in license of rpcstack.go 1/0/0
node (1)
1/1
node/rpcstack.go (4)
#20865 accounts/abi/bind: fixed erroneous filtering of negative ints 2/0/0
accounts/abi/bind (2)
92/8
accounts/abi/bind/topics_test.go (150)
accounts/abi/bind/topics.go (50)
#20852 reduce/deprecate the usage of the ambiguous term "testnet" 17/0/0
cmd/geth (4)
core (3)
mobile (2)
params (2)
README.md (1)
cmd/devp2p (1)
cmd/utils (1)
core/forkid (1)
miner (1)
tests (1)
173/83
cmd/utils/flags.go (114)
README.md (80)
cmd/geth/main.go (54)
mobile/geth.go (40)
params/config.go (36)
‼️ #20837 les, les/lespay/client: add service value statistics and API 8/9/0
les/lespay/client (7)
les (6)
les/utils (2)
internal/web3ext (1)
p2p/enode (1)
2144/40
les/lespay/client/valuetracker.go (1030)
les/lespay/client/requestbasket.go (570)
les/lespay/client/timestats.go (474)
les/utils/expiredvalue.go (404)
les/lespay/client/requestbasket_test.go (322)
‼️ #20911 README: update min go version to 1.13 1/0/0
README.md (1)
1/1
README.md (4)
‼️ #20913 travis, appveyor, build, Dockerfile: bump Go to 1.14.2 5/0/0
build (1)
.travis.yml (1)
Dockerfile (1)
Dockerfile.alltools (1)
appveyor.yml (1)
40/17
.travis.yml (92)
appveyor.yml (10)
Dockerfile (4)
Dockerfile.alltools (4)
build/checksums.txt (4)
#20919 core/rawdb: fix data race between Retrieve and Close 1/0/0
core/rawdb (1)
6/4
core/rawdb/freezer_table.go (20)
#20764 accounts/abi: implement new fallback functions 12/0/0
accounts/abi (5)
accounts/abi/bind (4)
les/utils (2)
mobile (1)
445/94
accounts/abi/bind/bind_test.go (242)
accounts/abi/abi.go (232)
accounts/abi/bind/template.go (132)
accounts/abi/method.go (112)
accounts/abi/abi_test.go (100)
#20808 core/state/snapshot: implement disk iterator seek 24/0/0
core/rawdb (5)
core/state/snapshot (4)
trie (3)
core/state (2)
common (2)
eth/filters (1)
ethdb (1)
ethdb/leveldb (1)
ethdb/memorydb (1)
cmd/utils (1)
eth (1)
ethdb/dbtest (1)
les (1)
246/185
core/state/snapshot/disklayer_test.go (152)
ethdb/dbtest/testsuite.go (146)
core/rawdb/table_test.go (126)
ethdb/memorydb/memorydb.go (98)
ethdb/leveldb/leveldb.go (62)
⚠️ #20925 params: update CHTs for the 1.9.13 release 1/0/0
params (1)
16/16
params/config.go (64)

242 Changed files

🔍 File Lines Changed Linked PR
core/state/snapshot/iterator_test.go 1324 #20152
p2p/discover/v5_encoding.go 1318 #20750
core/state/snapshot/snapshot.go 1206 #20152
‼️ core/vm/instructions.go 1092 #20761
core/state/snapshot/difflayer.go 1066 #20152
⚠️ core/blockchain_test.go 1048 #20152
#20870
les/lespay/client/valuetracker.go 1030 #20837
core/state/snapshot/disklayer_test.go 1022 #20152
#20808
core/state/snapshot/difflayer_test.go 798 #20152
p2p/discover/v5_encoding_test.go 746 #20750
core/state/snapshot/snapshot_test.go 696 #20152
core/state/snapshot/iterator_fast.go 604 #20152
les/lespay/client/requestbasket.go 570 #20837
core/state/snapshot/generate.go 524 #20152
core/state/snapshot/journal.go 524 #20152
les/lespay/client/timestats.go 474 #20837
les/utils/expiredvalue.go 410 #20837
#20764
core/state/snapshot/iterator.go 408 #20152
#20808
‼️ eth/sync.go 364 #20780
#20695
accounts/abi/bind/topics.go 360 #20851
#20865
core/state/snapshot/disklayer.go 332 #20152
les/lespay/client/requestbasket_test.go 322 #20837
node/rpcstack.go 318 #20904
#20810
‼️ core/state/statedb.go 304
crypto/ecies/ecies.go 286 #20836
les/peer.go 276 #20828
#20509
#20837
les/lespay/client/timestats_test.go 274 #20837
les/lespay/client/valuetracker_test.go 270 #20837
core/state/snapshot/wipe.go 262 #20808
core/rawdb/table_test.go 256 #20703
#20808
core/state/snapshot/wipe_test.go 248 #20808
cmd/devp2p/discv5cmd.go 246 #20750
p2p/discover/v5_session.go 246 #20750
⚠️ accounts/abi/bind/bind_test.go 242 #20764
core/rawdb/accessors_snapshot.go 240 #20152
#20808
les/utils/expiredvalue_test.go 236 #20837
#20764
accounts/abi/abi.go 232 #20764
core/state/snapshot/iterator_binary.go 230 #20152
core/state/snapshot/conversion.go 228 #20812
⚠️ cmd/utils/flags.go 216 #20152
#20484
#20852
les/lespay/client/api.go 214 #20837
eth/api_test.go 208 #19645
cmd/checkpoint-admin/README.md 206 #20697
node/endpoints.go 198 #20810
‼️ eth/handler.go 190 #20780
#20695
cmd/devp2p/discv4cmd.go 186 #20750
core/rawdb/table.go 182 #20703
#20808
accounts/abi/bind/topics_test.go 182 #20851
#20865
‼️ eth/api.go 176 #19645
crypto/crypto_test.go 170 #20718
⚠️ console/console.go 170 #20667
‼️ node/node.go 166 #20824
#20789
#20810
‼️ core/blockchain.go 164 #20152
#20812
#20798
#20695
‼️ internal/ethapi/api.go 146 #20783
#20854
ethdb/dbtest/testsuite.go 146 #20808
les/protocol.go 134 #20837
⚠️ accounts/abi/bind/template.go 132 #20764
‼️ eth/backend.go 128 #20695
#20484
‼️ cmd/clef/main.go 122 #20789
#20782
#20810
⚠️ core/state/state_object.go 118
⚠️ consensus/ethash/ethash.go 118 #20484
node/node_test.go 116 #20810
accounts/abi/method.go 112 #20764
⚠️ crypto/crypto.go 112 #20718
‼️ .travis.yml 110 #20833
#20913
p2p/discover/v4_lookup_test.go 108 #20750
core/state/snapshot/account.go 108 #20152
⚠️ les/client.go 100 #20837
accounts/abi/abi_test.go 100 #20764
cmd/evm/runner.go 100 #20152
#20792
les/utils/weighted_select.go 100 #20509
ethdb/memorydb/memorydb.go 98 #20808
⚠️ core/state/dump.go 96 #19645
‼️ core/tx_pool_test.go 92 #20901
‼️ README.md 90 #20841
#20911
#20852
⚠️ miner/worker_test.go 86 #20667
crypto/ecies/ecies_test.go 80 #20836
les/serverpool.go 78 #20509
cmd/devp2p/dns_route53.go 78 #20819
#20820
accounts/abi/unpack_test.go 76 #20850
#20764
node/rpcstack_test.go 76 #20810
les/utils/exec_queue.go 74 #20509
core/state/snapshot/sort.go 72 #20152
‼️ internal/web3ext/web3ext.go 72 #20781
#20837
accounts/abi/bind/bind.go 70 #20764
p2p/discover/common.go 68 #20750
‼️ build/checksums.txt 68 #20901
#20913
p2p/discover/table_util_test.go 66 #20750
p2p/discover/v4_udp_test.go 64 #20750
⚠️ core/vm/runtime/runtime_test.go 64 #20761
ethdb/leveldb/leveldb.go 62 #20808
⚠️ cmd/geth/main.go 62 #20152
#20484
#20852
metrics/cpu_enabled.go 62 #20816
⚠️ cmd/geth/accountcmd_test.go 62 #20718
accounts/abi/unpack.go 60 #20850
#20851
accounts/abi/method_test.go 58 #20764
mobile/bind.go 58 #20888
#20764
‼️ cmd/geth/genesis_test.go 56 #20860
⚠️ core/vm/interpreter.go 56 #20761
consensus/ethash/algorithm_test.go 54 #20484
core/rawdb/schema.go 54 #20152
⚠️ core/state/statedb_test.go 52 #20808
metrics/cpu_disabled.go 46 #20816
⚠️ cmd/geth/chaincmd.go 46 #20152
#20738
#20852
‼️ cmd/geth/retesteth.go 44 #20484
#20810
metrics/timer_test.go 42 #20818
les/utils/exec_queue_test.go 40 #20509
⚠️ core/genesis.go 40 #20152
#20852
mobile/geth.go 40 #20852
common/bytes_test.go 38 #20808
ethdb/iterator.go 38 #20808
common/prque/lazyqueue_test.go 38 #20667
crypto/ecies/params.go 38 #20836
⚠️ core/vm/instructions_test.go 32 #20761
‼️ core/genesis_test.go 32 #20852
cmd/devp2p/dns_route53_test.go 32 #20820
graphql/service.go 32 #20824
#20810
mobile/params.go 30 #20852
⚠️ eth/helper_test.go 30 #20695
⚠️ eth/downloader/downloader_test.go 28 #20901
⚠️ eth/config.go 28 #20484
les/clientpool.go 28 #20808
cmd/clef/docs/setup.md 28 #20900
⚠️ cmd/geth/consolecmd.go 26 #20852
core/vm/opcodes.go 26
⚠️ accounts/abi/bind/base.go 24 #20764
metrics/cpu.go 24 #20816
p2p/discover/v4_udp.go 22 #20750
cmd/clef/intapi_changelog.md 22 #20782
core/vm/intpool.go 22 #20761
common/bytes.go 22 #20808
cmd/devp2p/crawl.go 20 #20843
#20750
core/rawdb/database.go 20 #20152
#20808
les/utils/weighted_select_test.go 20 #20509
core/vm/eips.go 20 #20761
core/rawdb/freezer_table.go 20 #20919
⚠️ core/state_prefetcher.go 18
les/distributor.go 18 #20509
eth/sync_test.go 18 #20695
⚠️ cmd/geth/usage.go 16 #20152
#20484
#20852
les/client_handler.go 16 #20837
p2p/discover/node.go 14 #20750
core/rawdb/freezer_table_test.go 12 #20779
‼️ eth/api_tracer.go 12
⚠️ core/state/journal.go 12 #20152
⚠️ eth/handler_test.go 12 #20897
#20808
⚠️ accounts/abi/bind/backends/simulated.go 12 #20152
accounts/scwallet/wallet.go 12 #20901
core/state/sync_test.go 12
appveyor.yml 10 #20913
p2p/discover/table.go 8 #20750
cmd/devp2p/dnscmd.go 8 #20801
⚠️ eth/tracers/tracers_test.go 8
⚠️ les/odr_test.go 8
core/state/iterator_test.go 8 #20152
#20808
core/forkid/forkid_test.go 8 #20852
cmd/puppeth/module_wallet.go 8 #20901
core/vm/runtime/runtime.go 8
⚠️ light/odr_test.go 8
⚠️ core/state/state_test.go 8
⚠️ .github/ISSUE_TEMPLATE.md 4 #20896
cmd/evm/staterunner.go 4 #20152
‼️ les/api_backend.go 4 #20783
Dockerfile.alltools 4 #20913
core/rawdb/accessors_chain.go 4 #20808
⚠️ light/trie.go 4
core/genesis_alloc.go 4 #20852
accounts/abi/argument.go 4 #20851
eth/filters/bench_test.go 4 #20808
‼️ Dockerfile 4 #20913
‼️ core/tx_pool.go 4 #20835
⚠️ core/vm/gas_table_test.go 4
core/vm/jump_table.go 4 #20761
‼️ build/ci.go 4 #20901
eth/fetcher/block_fetcher.go 4 #20861
p2p/discover/lookup.go 4 #20750
‼️ go.mod 4 #20777
⚠️ eth/protocol_test.go 4 #20695
les/txrelay.go 4 #20837
⚠️ node/api.go 4 #20810
⚠️ core/chain_makers.go 4 #20152
‼️ go.sum 4 #20777
⚠️ eth/bloombits.go 4 #20695
miner/stress_ethash.go 4 #20852
‼️ eth/api_backend.go 4 #20783
cmd/devp2p/nodesetcmd.go 4 #20852
cmd/utils/cmd.go 4 #20808
⚠️ eth/filters/filter.go 4 #20827
les/benchmark.go 4 #20837
les/peer_test.go 4 #20897
⚠️ miner/worker.go 2 #20857
event/event_test.go 2 #20667
⚠️ ethstats/ethstats.go 2 #20867
⚠️ eth/filters/api.go 2 #20862
cmd/wnode/main.go 2 #20843
metrics/sample_test.go 2 #20866
les/costtracker.go 2 #20864
cmd/devp2p/main.go 2 #20750
metrics/meter_test.go 2 #20866
event/feed_test.go 2 #20868
rpc/metrics.go 0 #20847
p2p/discover/v5_udp_test.go 0 #20750
⚠️ signer/core/api.go 0 #20782
‼️ rpc/endpoints.go 0 #20776
#20824
#20810
whisper/whisperv6/peer.go 0 #20844
⚠️ params/version.go 0
whisper/mailserver/mailserver.go 0 #20901
#20891
⚠️ tests/vm_test_util.go 0
whisper/whisperv6/message_test.go 0 #20815
signer/core/uiapi.go 0 #20782
‼️ rpc/http.go 0 #20824
#20810
tests/state_test.go 0
whisper/whisperv6/whisper.go 0 #20843
#20844
p2p/discv5/sim_test.go 0 #20869
‼️ p2p/enode/node.go 0 #20837
params/bootnodes.go 0 #20852
⚠️ rpc/websocket.go 0 #20810
trie/iterator_test.go 0 #20808
p2p/discover/v5_udp.go 0 #20750
tests/transaction_test_util.go 0
⚠️ tests/block_test_util.go 0 #20812
docs/audits/2020-01-24_DiscV5_audit_Cure53.pdf 0 #20898
⚠️ params/config.go 0 #20925
#20852
⚠️ p2p/server.go 0 #20846
p2p/enode/nodedb.go 0 #20750
tests/vm_test.go 0
docs/audits/2019-10-15_Discv5_audit_LeastAuthority.pdf 0 #20898
p2p/enode/nodedb_test.go 0 #20750
⚠️ rpc/websocket_test.go 0 #20863
trie/proof_test.go 0 #20808
p2p/discv5/net.go 0 #20853
#20901
trie/sync_bloom.go 0 #20808
⚠️ rpc/client_test.go 0 #20667
rpc/subscription_test.go 0 #20667
whisper/whisperv6/peer_test.go 0 #20788
⚠️ rpc/handler.go 0 #20847
rpc/subscription.go 0 #20824
p2p/testing/protocolsession.go 0 #20869
rpc/gzip.go 0 #20810
⚠️ tests/block_test.go 0
tests/difficulty_test.go 0 #20852
⚠️ tests/state_test_util.go 0

karalabe and others added 30 commits February 25, 2020 12:51
This revision of go-duktype fixes the following warning

```
duk_logging.c: In function ‘duk__logger_prototype_log_shared’:
duk_logging.c:184:64: warning: ‘Z’ directive writing 1 byte into a region of size between 0 and 9 [-Wformat-overflow=]
  184 |  sprintf((char *) date_buf, "%04d-%02d-%02dT%02d:%02d:%02d.%03dZ",
      |                                                                ^
In file included from /usr/include/stdio.h:867,
                 from duk_logging.c:5:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:36:10: note: ‘__builtin___sprintf_chk’ output between 25 and 85 bytes into a destination of size 32
   36 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   37 |       __bos (__s), __fmt, __va_arg_pack ());
      |       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
holiman and others added 4 commits April 15, 2020 14:08
* core/state/snapshot: start fixing disk iterator seek

* ethdb, rawdb, leveldb, memorydb: implement iterators with prefix and start

* les, core/state/snapshot: iterator fixes

* all: remove two iterator methods

* all: rename Iteratee.NewIteratorWith -> NewIterator

* ethdb: fix review concerns
params: update CHTs for the 1.9.13 release
@ricardolyn ricardolyn marked this pull request as ready for review February 10, 2021 15:06
@ricardolyn ricardolyn requested a review from nmvalera February 10, 2021 15:06
@ricardolyn ricardolyn marked this pull request as draft February 10, 2021 15:41
@ricardolyn ricardolyn marked this pull request as ready for review February 10, 2021 15:52
node/endpoints.go Outdated Show resolved Hide resolved
node/node_test.go Outdated Show resolved Hide resolved
core/state/statedb.go Outdated Show resolved Hide resolved
core/state/statedb.go Outdated Show resolved Hide resolved
core/blockchain.go Outdated Show resolved Hide resolved
…155332

# Conflicts:
#       eth/handler.go
#       eth/helper_test.go
#       eth/sync_test.go
#
# It looks like you may be committing a merge.
# If this is not correct, please run
#       git update-ref -d MERGE_HEAD
# and try again.

# Please enter the commit message for your changes. Lines starting
# with '#' will be ignored, and an empty message aborts the commit.
#
# On branch upgrade/go-ethereum/v1.9.13-2021204155332
# Your branch is up to date with 'public_quorum/upgrade/go-ethereum/v1.9.13-2021204155332'.
#
# All conflicts fixed but you are still merging.
#
# Changes to be committed:
#       modified:   consensus/istanbul/backend/backend.go
#       modified:   consensus/istanbul/backend/handler.go
#       modified:   consensus/protocol.go
#       modified:   eth/backend.go
#       modified:   eth/handler.go
#       modified:   eth/peer.go
#       modified:   eth/protocol.go
#       modified:   eth/protocol_test.go
#       new file:   eth/quorum_protocol.go
#       modified:   eth/sync_test.go
#       modified:   p2p/peer.go
#
# Changes not staged for commit:
#       modified:   eth/handler.go
#       modified:   eth/helper_test.go
#       modified:   eth/quorum_protocol.go
#
Copy link
Contributor

@nmvalera nmvalera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ricardolyn ricardolyn merged commit 1e8568e into master Feb 12, 2021
@ricardolyn ricardolyn deleted the upgrade/go-ethereum/v1.9.13-2021204155332 branch February 12, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.