[Upgrade] Go-Ethereum release v1.9.18 #1142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
core/vm: use pointers to operations vs. copy by value
Fixes #21175 Co-authored-by: sammy007 <sammy007@users.noreply.github.com> Co-authored-by: Adam Schmideg <adamschmideg@users.noreply.github.com>
cmd/utils: reuse existing genesis in persistent dev mode
…#21301) * geth,utils: implement configurable developer account options Prior to this change --dev (developer) mode generated one account with an empty password, irrespective of existing --password and --miner.etherbase options. This change makes --dev mode compatible with these existing flags. --dev mode may now be used in conjunction with --password and --miner.etherbase flags to configure the developer faucet using an existing keystore or in creating a new account. Signed-off-by: meows <b5c6@protonmail.com> * main: remove key/pass flags from usage developer section These flags are included already in other sections, and it is not desired to duplicate them. They were originally included in this section along with added support for these flags in the developer mode. Signed-off-by: meows <b5c6@protonmail.com>
This fixes the iOS framework build by naming the second parameter of the Signer interface method. The name is important because it becomes part of the objc method signature. Fixes #21340
* eth/downloader: refactor downloader + queue downloader, fetcher: throttle-metrics, fetcher filter improvements, standalone resultcache downloader: more accurate deliverytime calculation, less mem overhead in state requests downloader/queue: increase underlying buffer of results, new throttle mechanism eth/downloader: updates to tests eth/downloader: fix up some review concerns eth/downloader/queue: minor fixes eth/downloader: minor fixes after review call eth/downloader: testcases for queue.go eth/downloader: minor change, don't set progress unless progress... eth/downloader: fix flaw which prevented useless peers from being dropped eth/downloader: try to fix tests eth/downloader: verify non-deliveries against advertised remote head eth/downloader: fix flaw with checking closed-status causing hang eth/downloader: hashing avoidance eth/downloader: review concerns + simplify resultcache and queue eth/downloader: add back some locks, address review concerns downloader/queue: fix remaining lock flaw * eth/downloader: nitpick fixes * eth/downloader: remove the *2*3/4 throttling threshold dance * eth/downloader: print correct throttle threshold in stats Co-authored-by: Péter Szilágyi <peterke@gmail.com>
Solves issue#20582. Non-executable transactions should not be evicted on each tick if there are no promote transactions or if a pending/reset empties the pending list. Tests and logging expanded to handle these cases in the future. core/tx_pool: use a ts for each tx in the queue, but only update the heartbeat on promotion or pending replaced queuedTs proper naming
core: address comment
core: fix queued transaction eviction
deps: update uint256 to v1.1.1
ricardolyn
changed the base branch from
master
to
upgrade/go-ethereum/v1.9.17-2021219105839
|
|
…/go-ethereum/v1.9.18-2021224170947
…/go-ethereum/v1.9.18-2021224170947
Base automatically changed from
upgrade/go-ethereum/v1.9.17-2021219105839
to
master
March 1, 2021 11:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Plan & Analyse
As you review, list extra changes and/or tests to be implemented to ensure compatibility with GoQuorum specific features.
Build & Test
masterinto this branchExtra Changes & Tests
Go-Ethereum Release: Illium Elite (v1.9.18)
Release notes
Geth v1.9.18 is a bugfix release, fixing an occasional fast sync hang in the throttling mechanism (among other improvements):
--devchains unable to load back up (#21352).--devmode (#21301).gomobilebuilding and fix iOS framework builds (#21361, #21362).For a full rundown of the changes please consult the Geth 1.9.18 release milestone
As with all our previous releases, you can find the:
ethereum/client-go.Codebase changes assessment
Legend
File Stats: (A) Added, (M) Modified and (R) Removed
Line Stats: (A) Added and (R) Removed
Assessment:
12 Pull Requests
M/A/R
(files changed)
A/R
(lines changed)
core/vm: use pointers to operations vs. copy by valuecore/vm(3)core/vm/jump_table.go(326)core/vm/eips.go(30)core/vm/interpreter.go(12)les: make clientPool.connectedBias configurableles(3)les/clientpool.go(58)les/api.go(24)les/clientpool_test.go(8)ethclient: serialize negative block number as "pending"core/types(2)ethclient(2)core/types/gen_log_json.go(36)ethclient/ethclient_test.go(32)core/types/log.go(8)ethclient/ethclient.go(8)whisper/whisperv6: improve test error messageswhisper/whisperv6(1)whisper/whisperv6/whisper_test.go(378)cmd/utils: reuse existing genesis in persistent dev modecmd/utils(1)cmd/utils/flags.go(22)cmd/utils: implement configurable developer (--dev) account optionscmd/utils(1)cmd/utils/flags.go(40)build: fix GOBIN for gomobile commandsbuild(1)build/ci.go(10)mobile: fix build on iOSmobile(1)mobile/bind.go(4)eth/downloader: refactor downloader + queueeth/downloader(9)eth/fetcher(1)core/types(1)eth/downloader/queue.go(924)eth/downloader/queue_test.go(852)eth/downloader/resultstore.go(388)eth/downloader/peer.go(178)eth/downloader/downloader.go(176)core: fix queued transaction evictioncore(2)core/tx_pool_test.go(170)core/tx_pool.go(46)deps: update uint256 to v1.1.1go.mod(1)go.sum(1)go.sum(8)go.mod(4)params: upgrade CHTsparams(1)params/config.go(64)31 Changed files
eth/downloader/queue.goeth/downloader/queue_test.goeth/downloader/resultstore.gowhisper/whisperv6/whisper_test.gocore/vm/jump_table.goeth/downloader/peer.goeth/downloader/downloader.gocore/tx_pool_test.goeth/fetcher/block_fetcher.goeth/downloader/peer_test.goeth/downloader/downloader_test.goparams/config.goeth/downloader/statesync.gocmd/utils/flags.go#21301
les/clientpool.gocore/tx_pool.gocore/types/gen_log_json.goethclient/ethclient_test.gocore/vm/eips.goles/api.gocore/types/block.gocore/vm/interpreter.gobuild/ci.gogo.sumles/clientpool_test.gocore/types/log.goethclient/ethclient.goeth/downloader/metrics.goparams/version.gomobile/bind.gogo.mod