Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check nil pointer #1506

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Conversation

baptiste-b-pegasys
Copy link
Contributor

fixes #1491

Symptoms:
When a round change occurs, it is possible that the pending request is nil and that crashes the node.

Solution:
The best way found is to return an error for this case.

More:
Two other nil pointer checks that are not related to the issue.

in order to avoid node crash
and also some other nil pointer checks
@baptiste-b-pegasys baptiste-b-pegasys self-assigned this Sep 15, 2022
@antonydenyer antonydenyer merged commit 0b4dde3 into Consensys:master Sep 16, 2022
@baptiste-b-pegasys baptiste-b-pegasys deleted the fix/npe branch January 9, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quorum node crashing when running with QBFT
2 participants