Fix: block header times not being recorded correctly when using EmptyBlockPeriod #1605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baptiste-b-pegasys
approved these changes
Feb 21, 2023
Whilst the delay was be calculated correctly the block time that was recorded in the block header was not. This was leading to problems with the time difference between blocks when using the timestamp in the block header.
antonydenyer
force-pushed
the
fix/qbftEmptyBlockPeriodHeaderTime
branch
from
2652261 to
b4cdf1c
Compare
antonydenyer
changed the title
Krish1979
approved these changes
Feb 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst the delay was be calculated correctly the block time that was recorded in the block header was not. This was leading to problems with the time difference between blocks when using the timestamp in the block header.