Use EIP155 signer when needed #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmsam
approved these changes
May 23, 2018
|
Thanks @jpmsam - we were just looking at this issue, as we came across it when testing MetaMask with Kaleido (per https://kaleido.io/kaleido-meets-metamask/ ). We will look to pull in this fix. |
|
@peterbroadhurst thanks to @tsuzukit for his work and contribution. |
Szkered
pushed a commit
to Szkered/quorum
that referenced
this pull request
Jun 22, 2018
Use EIP155 signer when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to #344.
Tested with
Web3 1.0.0-beta.34andnetworkidandchainidof10.Private transaction uses
HomesteadSigneras before, but locally signed transaction with Web3 should useEIP155Signerdepending on the block number.networkidandchainidmust not be 1, because it will produceVvalue of37which is used to indicate transaction being private with Quorum. (So I think 7nodes example should be fixed too if this is correct fix to the issue)