Add configurable threshold for 'future block' check #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue-792-add-allowedFutureBlockTime
trung
reviewed
Mar 11, 2020
trung
changed the title
….com/SatpalSandhu61/quorum into issue-792-add-allowedFutureBlockTime
|
Temporarily closing this PR as I want to make the parameter name generic, not just for Istanbul. |
…Time' into issue-792-add-allowedFutureBlockTime
SatpalSandhu61
changed the title
|
PR has been reopened with changes to make it more generic and include Clique. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #792
Added configurable threshold for 'future block' check, in order to avoid spurious "block in the future" messages for Istanbul and Clique.
Threshold is specified in seconds, using
--allowedfutureblocktimecommand line argument.Note that there is a similar change for ethash in upstream geth (albeit a fixed threshold, not configurable): https://github.com/ethereum/go-ethereum/blob/master/consensus/ethash/consensus.go#L248