Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix premature abort during blocks processing for raft #881

Merged
merged 5 commits into from
Nov 29, 2019

Conversation

zzy96
Copy link
Contributor

@zzy96 zzy96 commented Nov 19, 2019

Fix #852

Prevent raft from updating persisted storage when bc.insertChain is interrupted. This fixes the issue of chain fork and constant InvalidRaftOrdering.

@zzy96 zzy96 force-pushed the fix-raft-blocks-processing-premature-abort branch from aa8c26c to 718a43c Compare November 25, 2019 02:54
@jpmsam jpmsam requested a review from jbhurat November 29, 2019 16:14
Copy link
Contributor

@jbhurat jbhurat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpmsam jpmsam merged commit b7edc0b into master Nov 29, 2019
@zzy96 zzy96 deleted the fix-raft-blocks-processing-premature-abort branch November 30, 2019 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two minters possible in a 3-node network in Raft resulting in fork
4 participants