-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raft.cluster api returns error if no leader is there in the network in version 2.4.0 #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # docs/Features/dns.md
…twork. Fixed the same. added nodeActive attribute to the api response which indicates if the node is active in raft cluster. added error handling for other apis
jbhurat
previously approved these changes
Feb 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fixanoid
previously approved these changes
Feb 3, 2020
jpmsam
previously approved these changes
Feb 4, 2020
jbhurat
dismissed stale reviews from jpmsam, fixanoid, and themself
via
February 4, 2020 17:34
2608b97
jpmsam
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Quorum version 2.4.0, call to raft.cluster returns in error no leader is currently elected if the network is not having a leader node. This is different from behaviour in version where all nodes part of cluster are listed even when the leader is not elected.
This fix addresses the same. The api response has been addressed to include a new attribute nodeActive which will be true if the node is part for raft cluster else will be false. Further if the network is not having a valid leader, the role of each node will be shown as "" . Error handling added for other apis.
#931