extract methods

Consensys · Jul 25, 2024 · ef962b1 · ef962b1
1 parent b9604a8
commit ef962b1
Showing 1 changed file with 15 additions and 10 deletions.
diff --git a/...main/java/tech/pegasys/teku/statetransition/attestation/MatchingDataAttestationGroup.java b/...main/java/tech/pegasys/teku/statetransition/attestation/MatchingDataAttestationGroup.java
@@ -149,18 +149,11 @@ public Stream<ValidatableAttestation> stream(final Optional<UInt64> committeeInd
 
   public Stream<ValidatableAttestation> stream(
       final Optional<UInt64> committeeIndex, final boolean requiresCommitteeBits) {
-    // Group Attestation type mismatch
-    if (requiresCommitteeBits != includedValidators.requiresCommitteeBits()) {
+    if (noMatchingAttestations(committeeIndex, requiresCommitteeBits)) {
       return Stream.empty();
+    } else {
+      return StreamSupport.stream(spliterator(committeeIndex), false);
     }
-    // Pre electra attestation and committee index not matching
-    if (committeeIndex.isPresent()
-        && !includedValidators.requiresCommitteeBits()
-        && !attestationData.getIndex().equals(committeeIndex.get())) {
-      return Stream.empty();
-    }
-    // Filter based on the committee index
-    return StreamSupport.stream(spliterator(committeeIndex), false);
   }
 
   public Spliterator<ValidatableAttestation> spliterator(final Optional<UInt64> committeeIndex) {
@@ -245,6 +238,18 @@ public boolean matchesCommitteeShufflingSeed(final Set<Bytes32> validSeeds) {
     return committeeShufflingSeed.map(validSeeds::contains).orElse(false);
   }
 
+  private boolean noMatchingAttestations(
+      Optional<UInt64> committeeIndex, boolean requiresCommitteeBits) {
+    return requiresCommitteeBits != includedValidators.requiresCommitteeBits()
+        || noMatchingPhase0Attestations(committeeIndex);
+  }
+
+  private boolean noMatchingPhase0Attestations(Optional<UInt64> committeeIndex) {
+    return committeeIndex.isPresent()
+        && !includedValidators.requiresCommitteeBits()
+        && !attestationData.getIndex().equals(committeeIndex.get());
+  }
+
   private class AggregatingIterator implements Iterator<ValidatableAttestation> {
 
     private final Optional<UInt64> maybeCommitteeIndex;