Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bellatrix Acceptance Test #5074

Closed
tbenr opened this issue Mar 1, 2022 · 3 comments · Fixed by #6019
Closed

Bellatrix Acceptance Test #5074

tbenr opened this issue Mar 1, 2022 · 3 comments · Fixed by #6019
Assignees

Comments

@tbenr
Copy link
Contributor

tbenr commented Mar 1, 2022

Description

We should have acceptance tests that checks teku behaviour with Bellatrix is activated, ideally going through the transition block.
We could think about adding complexity by test several scenarios (ie. optimistic sync)

An option is to have extended AT by running a fixed besu client version capable of running as EL.

Another option is to start using kurtosis.

https://docs.kurtosistech.com/

https://github.com/kurtosis-tech/eth2-merge-kurtosis-module

Pari is already running it daily to check various client compatibility:

https://github.com/parithosh/nightly-kurtosis-test/blob/main/.github/workflows/kurtosis.yml
https://github.com/parithosh/nightly-kurtosis-test/actions

additional examples:
https://notes.ethereum.org/@ExXcnR0-SJGthjz1dwkA1A/H11OzhRAK

@ajsutton
Copy link
Contributor

ajsutton commented Mar 1, 2022

This would actually be an acceptance test in our terminology as it would be end-to-end.

@ajsutton ajsutton changed the title Bellatrix Integration Test Bellatrix Acceptance Test Mar 1, 2022
@zilm13 zilm13 self-assigned this Jun 3, 2022
@zilm13
Copy link
Contributor

zilm13 commented Jul 11, 2022

What tests could be done next:

@rolfyone rolfyone added blocks another PR/issue 🛡 This issue or pull request blocks another blocked by another PR/issue 💔 This issue or pull request is blocked by another and removed blocks another PR/issue 🛡 This issue or pull request blocks another labels Jul 14, 2022
@rolfyone rolfyone removed the blocked by another PR/issue 💔 This issue or pull request is blocked by another label Jul 28, 2022
@zilm13
Copy link
Contributor

zilm13 commented Jul 28, 2022

Though both blockers are merged we couldn't yet finish this until hyperledger/besu#3988 fix is included in release, so we could update Besu version used in acceptance tests. When the fix reaches release, we will need to add to OptimisticSyncPostMergeAcceptanceTest and OptimisticSyncSafeSlotsAcceptanceTest logic to enable sync with disconnected execution client and wait for non-optimistic block

@zilm13 zilm13 added the blocked by another PR/issue 💔 This issue or pull request is blocked by another label Jul 28, 2022
@zilm13 zilm13 removed the blocked by another PR/issue 💔 This issue or pull request is blocked by another label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants