Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for passing merge with optimistic import after safe slots #5989

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Add test for passing merge with optimistic import after safe slots #5989

merged 2 commits into from
Jul 29, 2022

Conversation

zilm13
Copy link
Contributor

@zilm13 zilm13 commented Jul 28, 2022 •
edited
Loading

PR Description

Acceptance test passes the Merge after SAFE_SLOTS_TO_IMPORT_OPTIMISTICALLY with EL still syncing.
Not closing #5074 yet, because testing of switching from optimistic sync back to normal is still blocked, see #5074

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

ajsutton
ajsutton approved these changes Jul 29, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zilm13 zilm13 merged commit fbfa37b into Consensys:master Jul 29, 2022
@zilm13 zilm13 deleted the tests/acceptance-safe-slots branch July 29, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zilm13 @ajsutton