Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make P2PDebugDataDumper more generic #8259

Closed
StefanBratanov opened this issue Apr 29, 2024 · 0 comments · Fixed by #8376
Closed

Make P2PDebugDataDumper more generic #8259

StefanBratanov opened this issue Apr 29, 2024 · 0 comments · Fixed by #8376
Assignees

Comments

@StefanBratanov
Copy link
Contributor

StefanBratanov commented Apr 29, 2024

There is value in making P2PDebugDataDumper more generic. Currently, name is slightly misleading, since for example saveInvalidBlockToFile can occur when syncing or when called via the beacon-API, so it is not strictly P2P. We could rename --Xp2p-dumps-to-file-enabled to sth like --Xdebug-data-dumping-enabled and rename P2PDebugDataDumper to DebugDataDumper and use it in several places. Some options are;

  • dump blob sidecars when is_data_available fails
  • dump blobs bundle coming from builder if it fails the consistency checks
@StefanBratanov StefanBratanov changed the title Make P2PDebugDataDumper cover more cases Make P2PDebugDataDumper more generic Apr 29, 2024
@StefanBratanov StefanBratanov self-assigned this Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant