You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is value in making P2PDebugDataDumper more generic. Currently, name is slightly misleading, since for example saveInvalidBlockToFile can occur when syncing or when called via the beacon-API, so it is not strictly P2P. We could rename --Xp2p-dumps-to-file-enabled to sth like --Xdebug-data-dumping-enabled and rename P2PDebugDataDumper to DebugDataDumper and use it in several places. Some options are;
dump blob sidecars when is_data_available fails
dump blobs bundle coming from builder if it fails the consistency checks
The text was updated successfully, but these errors were encountered:
StefanBratanov
changed the title
Make P2PDebugDataDumper cover more cases
Make P2PDebugDataDumper more generic
Apr 29, 2024
There is value in making
P2PDebugDataDumper
more generic. Currently, name is slightly misleading, since for examplesaveInvalidBlockToFile
can occur when syncing or when called via the beacon-API, so it is not strictlyP2P
. We could rename--Xp2p-dumps-to-file-enabled
to sth like--Xdebug-data-dumping-enabled
and renameP2PDebugDataDumper
toDebugDataDumper
and use it in several places. Some options are;is_data_available
failsThe text was updated successfully, but these errors were encountered: