Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump blob sidecars which failed data availability #8376

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Jun 13, 2024

PR Description

Dump blob sidecars which failed the data availability check (invalid)

Fixed Issue(s)

fixes #8259

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr
Copy link
Contributor

tbenr commented Jun 13, 2024

I perfectly get the INVALID dump, but dumping the available but incomplete ones seems... weird

the INVALID is more "one or more of the dumped ones is invalid".

the invalid will be kept by the gossip validation first (in most cases), so I guess we will dump it as a raw message

@StefanBratanov
Copy link
Contributor Author

StefanBratanov commented Jun 13, 2024

I perfectly get the INVALID dump, but dumping the available but incomplete ones seems... weird

the INVALID is more "one or more of the dumped ones is invalid".

the invalid will be kept by the gossip validation first (in most cases), so I guess we will dump it as a raw message

Thanks, actually you are right NOT_AVAILABLE is empty sidecars, so no reason. I changed the code a bit where basically we only dump the sidecars on INVALID but also dump the kzg commitments from the block. Got rid of the failure reason and throwable since only used in logging which I don't think it's necessary looking at the code.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) June 18, 2024 17:39
@StefanBratanov StefanBratanov merged commit fb21b1a into Consensys:master Jun 18, 2024
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make P2PDebugDataDumper more generic
2 participants