Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge] Unhide merge related CLI options #5150

Merged
merged 8 commits into from
Mar 10, 2022
Merged

[Merge] Unhide merge related CLI options #5150

merged 8 commits into from
Mar 10, 2022

Conversation

courtneyeh
Copy link
Contributor

fixes #4874

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

ajsutton
ajsutton reviewed Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say --Xee-version can stay hidden since we'll likely wind up only maintaining one version pretty soon anyway (once kintsugi dies we can just use the kilnv2 version).

@courtneyeh courtneyeh marked this pull request as ready for review March 10, 2022 03:31
ajsutton
ajsutton approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@courtneyeh courtneyeh merged commit 54908d0 into Consensys:master Mar 10, 2022
@courtneyeh courtneyeh deleted the merge-cli-options branch March 10, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Merge] Unhide merge related CLI options
2 participants
@courtneyeh @ajsutton