Update optimistic import rules #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can now import a block optimistically if it's parent has a non-default payload or if it is sufficiently old. Also moves the logic for determining if optimistic import is allowed into the spec module since it's a function from the spec itself.
tbenr
approved these changes
Mar 30, 2022
| } | ||
|
|
||
| @Test | ||
| void isOptimisticSyncPossible_shouldBeFalseWhenBlockIsMergeButNotOldEnough() { |
There was a problem hiding this comment.
nit: rename to canOptimisticallyImport_
| } | ||
|
|
||
| @Test | ||
| void isOptimisticSyncPossible_shouldBeTrueWhenBlockIsMergeAndIsOldEnough() { |
There was a problem hiding this comment.
nit: rename to canOptimisticallyImport_
Comment on lines
468
to
470
| final boolean isExecutionBlock = | ||
| parentExecutionRoot.isPresent() && !parentExecutionRoot.get().isZero(); | ||
| return isExecutionBlock; |
There was a problem hiding this comment.
nit: the local boolean isExecutionBlock seems a bit redundant to me. The method itself has that name and should be enough to understand the objective.
There was a problem hiding this comment.
IntelliJ agrees. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Can now import a block optimistically if it's parent has a non-default payload or if it is sufficiently old.
Also moves the logic for determining if optimistic import is allowed into the spec module since it's a function from the spec itself.
Fixed Issue(s)
fixes #5105
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog