Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds sync committee metrics #6891

Merged
merged 14 commits into from
Mar 3, 2023
Merged

Adds sync committee metrics #6891

merged 14 commits into from
Mar 3, 2023

Conversation

rolfyone
Copy link
Contributor

@rolfyone rolfyone commented Mar 2, 2023

validator_scheduled_sync_committee_duties_current This new metric is a visualisation to see how many validators are currently assigned to performing sync committee duties.

There were already metrics showing the attestation duties and block production duties, named in the same way, so this was just filling in the gap, although the other duties are accounted in a slightly different way, as they work differently.

This new metric is effectively the number of validators that you have that are in a sync committee currently.

Also added
validator_current_sync_committee_last_epoch, which will be the last epoch of the current sync committee.

This will allow validator maintainers to better determine if they are in a sync committee currently, and when the sync committee will be changing.

Fixes #6270

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

`validator_scheduled_sync_committee_duties_current`
This new metric is a visualisation to see how many validators are currently assigned to performing sync committee duties.

There were already metrics showing the attestation duties and block production duties, named in the same way, so this was just filling in the gap, although the other duties are accounted in a slightly different way, as they work differently.

This new metric is effectively the number of validators that you have that are in a sync committee currently.

Also added
`validator_current_sync_committee_last_epoch`, which will be the last epoch of the current sync committee.

This will allow validator maintainers to better determine if they are in a sync committee currently, and when the sync committee will be changing.

Fixes Consensys#6270

Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just need to deal with the duplicated test.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@rolfyone rolfyone enabled auto-merge (squash) March 2, 2023 22:39
@rolfyone rolfyone disabled auto-merge March 3, 2023 01:45
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
Signed-off-by: Paul Harris <paul.harris@consensys.net>
@rolfyone rolfyone enabled auto-merge (squash) March 3, 2023 05:37
@rolfyone rolfyone merged commit e895b42 into Consensys:master Mar 3, 2023
@rolfyone rolfyone deleted the 6270 branch March 3, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose current sync committee and next sync committee per pubkey in the validator prometheus metrics
2 participants