Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors on reporting tasks #7062

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Handle errors on reporting tasks #7062

merged 1 commit into from
Apr 20, 2023

Conversation

lucassaldanha
Copy link
Member

PR Description

Handling errors when joining reporting task futures to avoid bubbling them up all the way to our global exception handler.

Fixed Issue(s)

fixes #7023

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha lucassaldanha enabled auto-merge (squash) April 19, 2023 23:19
rolfyone
rolfyone approved these changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha merged commit 196c4c1 into Consensys:master Apr 20, 2023
@lucassaldanha lucassaldanha deleted the handle-error branch April 21, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

antithesis test had 'please fix or report' message
2 participants
@lucassaldanha @rolfyone