Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign voluntary exits using the Capella fork domain post Deneb #7394

Conversation

StefanBratanov
Copy link
Contributor

PR Description

Related to ethereum/consensus-specs#3288

We were not using the capella fork domain for signing exits which occur post Deneb fork.

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov force-pushed the sign_voluntary_exit_with_capella_fork branch 2 times, most recently from eb025d6 to a53c758 Compare July 28, 2023 08:11
@StefanBratanov StefanBratanov force-pushed the sign_voluntary_exit_with_capella_fork branch from a53c758 to 28545b1 Compare July 28, 2023 18:37
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) July 30, 2023 09:05
@StefanBratanov StefanBratanov merged commit 7ad3469 into Consensys:master Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants