Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use official trusted setup #7609

Merged
merged 9 commits into from
Oct 20, 2023
Merged

Use official trusted setup #7609

merged 9 commits into from
Oct 20, 2023

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Oct 19, 2023 •
edited
Loading

PR Description

  • Use official trusted setup as per Use official KZG ceremony output trusted setups ethereum/consensus-specs#3521
  • Update jc-kzg-4844 library to 0.8.0 which targets v0.4.0 of c-kzg-4844
  • Change tests around which were using minimal trusted setups
  • Update ref tests to v1.4.0-beta.3
  • Simplified CKZG4844 to not expose loadTrustedSetup(TrustedSetup) since only used privately
  • Simplified KzgTestExecutor
  • Changed presets in several places to match the ones in the consensus-specs repo

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@StefanBratanov StefanBratanov marked this pull request as draft October 19, 2023 16:19
@StefanBratanov StefanBratanov marked this pull request as ready for review October 20, 2023 07:03
@StefanBratanov StefanBratanov mentioned this pull request Oct 20, 2023
Closed
@StefanBratanov StefanBratanov mentioned this pull request Oct 20, 2023
Closed
tbenr
tbenr approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 0d4f9eb into Consensys:master Oct 20, 2023
4 checks passed
@StefanBratanov StefanBratanov deleted the official_trusted_setup branch October 20, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StefanBratanov @tbenr