Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exit when no validator keys #7829

Merged
merged 6 commits into from
Dec 14, 2023
Merged

Fix exit when no validator keys #7829

merged 6 commits into from
Dec 14, 2023

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Dec 14, 2023 •
edited
Loading

Since initialization is async, I ended up doing the same thing we do on doppleganger detection.

Actually acceptance tests were testing the bug! Interop keys were loaded and node was still exiting.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr changed the title fix-exit-when-no-validator-keys Fix exit when no validator keys Dec 14, 2023
zilm13
zilm13 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr enabled auto-merge (squash) December 14, 2023 16:39
@tbenr tbenr merged commit 1f98f19 into Consensys:master Dec 14, 2023
15 checks passed
@tbenr tbenr deleted the fix-exit-when-no-validator-keys branch December 14, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zilm13 zilm13 zilm13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbenr @zilm13