[BEACON API] SSE for block builders #7837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
force-pushed
the
sse_block_building
branch
2 times, most recently
from
83e2057
to
e6396f8
Compare
zilm13
approved these changes
Dec 20, 2023
| "parent_beacon_block_root", | ||
| BYTES32_TYPE, | ||
| payloadAttributes -> | ||
| Optional.ofNullable(payloadAttributes.getParentBeaconBlockRoot())) |
There was a problem hiding this comment.
I'm not 100% sure, but we fill it always, so even for V1 we will set this field, which is not good I think
There was a problem hiding this comment.
hmmmm yeah you are right, not sure how to do this, got any idea?
There was a problem hiding this comment.
I think the cleanest way is to make additional record with only needed fields filled in accordance with "milestone.isGreater or" and passing it here instead of PayloadBuildingAttributes
There was a problem hiding this comment.
ok got it, done. wdyt?
...src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/events/PayloadAttributesEvent.java
Outdated
Show resolved
Hide resolved
...sition/src/main/java/tech/pegasys/teku/statetransition/block/NewBlockBuildingSubscriber.java
Show resolved
Hide resolved
...src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/events/PayloadAttributesEvent.java
Outdated
Show resolved
Hide resolved
|
Also added issue #7847 as per talk |
StefanBratanov
force-pushed
the
sse_block_building
branch
from
850997b
to
fa3fbf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Implement ethereum/beacon-APIs#244
payload_attributesEventType andPayloadAttributesEventNewBlockBuildingSubscriberto be notified whenever new block is being built with all the information needed for the event as per the specForkChoiceNotifierImplFixed Issue(s)
fixes #6817
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog