Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change comment (getting finalized checkpoint from store rather than state #7926

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Change comment (getting finalized checkpoint from store rather than state #7926

merged 1 commit into from
Jan 25, 2024

Conversation

StefanBratanov
Copy link
Contributor

PR Description

We already get the finalizedCheckpoint from the store when constructing P2P Status message and for block and blob sidecars gossip validation, so just changed a comment.

image

image

Fixed Issue(s)

fixes #7905

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

tbenr
tbenr approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov merged commit 524809a into Consensys:master Jan 25, 2024
15 checks passed
@StefanBratanov StefanBratanov deleted the change_comment branch January 25, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbenr tbenr tbenr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CONSENSUS SPEC] use finalized checkpoint from store rather than state
2 participants
@StefanBratanov @tbenr