Improve block equivocation check for block publishing V2 API #8043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revisit enum names
tbenr
changed the title
zilm13
reviewed
Mar 6, 2024
.../src/test/java/tech/pegasys/teku/statetransition/validation/BlockBroadcastValidatorTest.java
Show resolved
Hide resolved
...nsition/src/main/java/tech/pegasys/teku/statetransition/validation/BlockGossipValidator.java
Outdated
Show resolved
Hide resolved
...nsition/src/main/java/tech/pegasys/teku/statetransition/validation/BlockGossipValidator.java
Outdated
Show resolved
Hide resolved
| return EQUIVOCATING_BLOCK_FOR_SLOT_PROPOSER; | ||
| } | ||
|
|
||
| EquivocationCheckResult performBlockEquivocationCheck(final SignedBeaconBlock block) { |
There was a problem hiding this comment.
and also here I think something like performIntermediateBlockEquivocationCheck will highlight purpose
There was a problem hiding this comment.
mm... here I disagree because it is called to do the final equivocation check when building the pipeline in buildValidationPipeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion happening in the issue.
The objective is to make gossip broadcast validation to fail only in case of equivocating blocks (slashable, proposer proposed two different blocks for the same slot) and let it pass when it is the same block root that is causing the gossip ignore.
In case of "already seen", we can say for sure that the block has been seen but we currently don't know anything about blobs. So the current decision is to publish block and blobs in that condition too, and let the libp2p layer to filter the already seen. If detected we log a debug line with the exception:
fixes #8039
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog