Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use slot-based SchemaDefinitions when creating/singing block for Deneb #8047

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

StefanBratanov
Copy link
Contributor

PR Description

We are specifically getting SchemaDefinitionsDeneb for milestone DENEB when creating/signing block

spec.forMilestone(SpecMilestone.DENEB).getSchemaDefinitions())

This breaks if we need to propose a block for later milestones where the block structure has changed. (e.g. Electra)

Fixed Issue(s)

N/A

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) March 6, 2024 15:13
@StefanBratanov StefanBratanov merged commit 51807fb into Consensys:master Mar 6, 2024
15 checks passed
@StefanBratanov StefanBratanov deleted the fix-issue branch March 6, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants