7549 - VC aggregation #8300
Merged
7549 - VC aggregation #8300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rolfyone
reviewed
May 8, 2024
| @@ -170,7 +170,7 @@ private String formatBlockRoots(final Set<Bytes32> blockRoots) { | |||
| return blockRoots.stream().map(LogFormatter::formatHashRoot).collect(Collectors.joining(", ")); | |||
| } | |||
|
|
|||
| public void aggregationSkipped(final UInt64 slot, final int committeeIndex) { | |||
| public void aggregationSkipped(final UInt64 slot, final UInt64 committeeIndex) { | |||
There was a problem hiding this comment.
we only see this used in test code in this PR which is curious... if its only testing code we should probably move it, and Im less concerned with the interface change, otherwise i think committeeIndex would have been better to stay as int :)
There was a problem hiding this comment.
I had a back and forth among int<->UInt64. I landed there just to maintain similarity to validatorIndex.
And i also saw some UInt64 related to committteeIndex in some API params.
There was a problem hiding this comment.
why you say it is only used in testing? I see this :)
There was a problem hiding this comment.
weird that interface changes and calling point doesnt...
rolfyone
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ValidatorApiChannel::createAggregateby adding an optionalcommitteeIndexto allow BN to know about committee to aggregate for. (Implemented only for in-process VC)MatchingDataAttestationGroup) to apply the committee filtering if required.Related to #7965
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog