Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetBlockAttestationV2 #8434

Merged
merged 6 commits into from
Jul 15, 2024
Merged

GetBlockAttestationV2 #8434

merged 6 commits into from
Jul 15, 2024

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Jul 10, 2024 •
edited
Loading

PR Description

Fixed Issue(s)

fixes #8264

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha lucassaldanha added DO NOT MERGE Not ready to merge and removed DO NOT MERGE Not ready to merge labels Jul 10, 2024
@lucassaldanha lucassaldanha marked this pull request as ready for review July 11, 2024 04:58
rolfyone
rolfyone approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, potentially we could improve how we unit test here as discussed.

@lucassaldanha lucassaldanha enabled auto-merge (squash) July 15, 2024 04:58
@lucassaldanha lucassaldanha merged commit e4b7c9e into Consensys:master Jul 15, 2024
16 checks passed
@lucassaldanha lucassaldanha deleted the teku-8264 branch July 31, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the block attestations v2 API
2 participants
@lucassaldanha @rolfyone