Add GetAttesterSlashingV2 implementation #8471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Implemented the GetAttesterSlashingV2 method for the beacon API, including endpoint definition, handler, and tests.
- Added
data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/paths/_eth_v2_beacon_pool_attester_slashings.jsonfor OpenAPI spec. - Implemented
data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/GetAttesterSlashingsV2.javafor the new endpoint. - Updated
data/provider/src/main/java/tech/pegasys/teku/api/NodeDataProvider.javato includegetAttesterSlashingsAndMetaDatamethod. - Added unit tests in
data/beaconrestapi/src/test/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/GetAttesterSlashingsV2Test.java. - Included test data files
getAttesterSlashingsElectra.jsonandgetAttesterSlashingsPhase0.jsonfor different spec milestones.
9 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
…GetAttesterSlashingV2Impl
rolfyone
reviewed
Jul 25, 2024
...ources/tech/pegasys/teku/beaconrestapi/beacon/schema/GetPoolAttesterSlashingsV2Response.json
Outdated
Show resolved
Hide resolved
rolfyone
approved these changes
Jul 25, 2024
Signed-off-by: Gabriel Fukushima <gabrielfukushima@gmail.com>
# Conflicts: # data/beaconrestapi/src/integration-test/resources/tech/pegasys/teku/beaconrestapi/beacon/schema/GetPoolAttesterSlashingsV2Response.json # data/beaconrestapi/src/main/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/GetAttesterSlashingsV2.java # data/beaconrestapi/src/test/java/tech/pegasys/teku/beaconrestapi/handlers/v2/beacon/GetAttesterSlashingsV2Test.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds the implementation of the handle for the GetAttesterSlashingV2 method of the beacon API.
Fixed Issue(s)
Fixes #8122
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog